Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1524063002: X87: [turbofan] Store nodes use only MachineRepresentation, not MachineType. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Store nodes use only MachineRepresentation, not MachineType. port 56673804e026b297a5165e6f807f55aaaad6c6ee (r32803) original commit message: BUG= Committed: https://crrev.com/bc895e62ed571970facb7a23da010eef15002b2b Cr-Commit-Position: refs/heads/master@{#32854}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-15 07:17:39 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-15 08:21:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1524063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1524063002/1
5 years ago (2015-12-15 08:22:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 08:45:22 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 08:46:05 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bc895e62ed571970facb7a23da010eef15002b2b
Cr-Commit-Position: refs/heads/master@{#32854}

Powered by Google App Engine
This is Rietveld 408576698