Chromium Code Reviews
Help | Chromium Project | Sign in
(30)

Issue 1524021: Add repo_name for overlays. All overlays should have repo_name defined (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by tedbo
Modified:
2 years, 11 months ago
CC:
chromium-os-reviews_googlegroups.com, robotboy
Visibility:
Public.

Description

Add repo_name for overlays. All overlays should have repo_name defined
since it ends up as part of binary package metadata.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change to match board names as suggested by piman #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Lint Patch
A src/overlays/overlay-arm-generic/profiles/repo_name View 1 chunk +1 line, -0 lines 0 comments ? errors Download
A src/overlays/overlay-beagleboard/profiles/repo_name View 1 chunk +1 line, -0 lines 0 comments ? errors Download
A src/overlays/overlay-st1q/profiles/repo_name View 1 chunk +1 line, -0 lines 0 comments ? errors Download
A src/overlays/overlay-tegra2-dev-board/profiles/repo_name View 1 chunk +1 line, -0 lines 0 comments ? errors Download
A src/overlays/overlay-variant-st1q-st15q/profiles/repo_name View 1 1 chunk +1 line, -0 lines 0 comments ? errors Download
A src/overlays/overlay-variant-voguev210-evt0/profiles/repo_name View 1 1 chunk +1 line, -0 lines 0 comments ? errors Download
A src/overlays/overlay-voguev210/profiles/repo_name View 1 chunk +1 line, -0 lines 0 comments ? errors Download
A src/overlays/overlay-x86-generic/profiles/repo_name View 1 chunk +1 line, -0 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 3
tedbo
4 years ago #1
piman
http://codereview.chromium.org/1524021/diff/1/6 File src/overlays/overlay-variant-st1q-st15q/profiles/repo_name (right): http://codereview.chromium.org/1524021/diff/1/6#newcode1 src/overlays/overlay-variant-st1q-st15q/profiles/repo_name:1: st1q-st15q I would rename this st1q_st15q for consistency with ...
4 years ago #2
Mandeep Singh Baines
4 years ago #3
LGTM

Wish we were consistent with either ${BOARD}-${OVERLAY} or ${BOARD}_${OVERLAY}.

Anyone know why we use one in one context and another in another context? I
guess we need the '_' as a field separator. Maybe we should clean up to use
that.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6