Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1523993003: X87: [proxy] fixing for-in for proxies, fixing harmony/proxy.js tests, improving error messages and… (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [proxy] fixing for-in for proxies, fixing harmony/proxy.js tests, improving error messages and some drive-by fixes. port df2a92972b0a087080e67496177e879e9409d5b0 (r32801) original commit message: BUG= Committed: https://crrev.com/d922d4e5d136d2692a75e6cf9bea362c0b401140 Cr-Commit-Position: refs/heads/master@{#32853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-15 07:15:10 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-15 08:21:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523993003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523993003/1
5 years ago (2015-12-15 08:21:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 08:44:17 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 08:45:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d922d4e5d136d2692a75e6cf9bea362c0b401140
Cr-Commit-Position: refs/heads/master@{#32853}

Powered by Google App Engine
This is Rietveld 408576698