chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc - Issue 1523953004: Fix volume slider to emit value changed events and do not focus system tray item for transient views

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Issue 1523953004: Fix volume slider to emit value changed events and do not focus system tray item for transient views (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revise comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/system/tray/system_tray.cc ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

diff --git a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

index ba4221227abfd19827a48ee9dce8148bc4ef363c..bc9b381c8c8a2a0fbb359d458394b4ed52e9ebc2 100644

--- a/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

+++ b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

@@ -422,6 +422,9 @@ IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, DISABLED_ScreenBrightness) {

IN_PROC_BROWSER_TEST_P(SpokenFeedbackTest, VolumeSlider) {

EnableChromeVox();

+ // Volume slider does not fire valueChanged event on first key press because

+ // it has no widget.

+ EXPECT_TRUE(PerformAcceleratorAction(ash::VOLUME_UP));

EXPECT_TRUE(PerformAcceleratorAction(ash::VOLUME_UP));

EXPECT_TRUE(

base::MatchPattern(speech_monitor_.GetNextUtterance(), "* percent*"));