Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 1523943002: Fix nil-deref panic from Put. (Closed)

Created:
5 years ago by iannucci
Modified:
5 years ago
Reviewers:
dnj, Vadim Sh., estaab, martiniss
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Fix nil-deref panic from Put. We were using key before checking the error. R=dnj@chromium.org, estaab@chromium.org, vadimsh@chromium.org BUG=https://github.com/luci/gae/issues/26 Committed: https://github.com/luci/gae/commit/663fbda0c98ea4adfa887a93f2c7404b84cdb3b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M service/datastore/datastore.go View 1 chunk +1 line, -2 lines 0 comments Download
M service/datastore/datastore_test.go View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
iannucci
5 years ago (2015-12-14 23:34:15 UTC) #1
iannucci
On 2015/12/14 at 23:34:15, iannucci wrote: > +martiniss
5 years ago (2015-12-14 23:34:39 UTC) #3
Vadim Sh.
lgtm
5 years ago (2015-12-14 23:36:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523943002/1
5 years ago (2015-12-14 23:37:10 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-14 23:42:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/663fbda0c98ea4adfa887a93f2c7404b84cdb3b6

Powered by Google App Engine
This is Rietveld 408576698