Subzero: Separate "\t" from "opcode" in asm emission.

Subzero: Separate "\t" from "opcode" in asm emission.

Instead of output like this:
  Str << "\tmov\t" << ...
we prefer to use string concatenation:
  Str << "\t" "mov\t" << ...

That way, "git grep -w mov" can be used for more precise pattern matching.

BUG= none
R=kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6106df803dbfd6f1cdf277bacb5437c567ec607f

[Jim Stichnoth, 2015-12-14 21:57:30]

Description was changed from

==========
Subzero: Separate "\t" from "opcode" in asm emission.

BUG= none
==========

to

==========
Subzero: Separate "\t" from "opcode" in asm emission.

Instead of output like this:
  Str << "\tmov\t" << ...
we prefer to use:
  Str << "\t" << "mov\t" << ...

That way, "git grep -w mov" can be used for more precise pattern matching.

BUG= none
==========

[Jim Stichnoth, 2015-12-14 21:57:30]

stichnot@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Roland McGrath, 2015-12-14 22:08:57]

If you use string concatentation instead, you get the same greppability with no
runtime overhead (no runtime change at all).
That is:
  Str << "\t" << "mov\t" << ...
->
  Str << "\t" "mov\t" << ...

[Jim Stichnoth, 2015-12-14 22:58:26]

Description was changed from

==========
Subzero: Separate "\t" from "opcode" in asm emission.

Instead of output like this:
  Str << "\tmov\t" << ...
we prefer to use:
  Str << "\t" << "mov\t" << ...

That way, "git grep -w mov" can be used for more precise pattern matching.

BUG= none
==========

to

==========
Subzero: Separate "\t" from "opcode" in asm emission.

Instead of output like this:
  Str << "\tmov\t" << ...
we prefer to use string concatenation:
  Str << "\t" "mov\t" << ...

That way, "git grep -w mov" can be used for more precise pattern matching.

BUG= none
==========

[Jim Stichnoth, 2015-12-14 23:00:39]

On 2015/12/14 22:08:57, Roland McGrath wrote:
> If you use string concatentation instead, you get the same greppability with
no
> runtime overhead (no runtime change at all).
> That is:
>   Str << "\t" << "mov\t" << ...
> ->
>   Str << "\t" "mov\t" << ...

Sweet, done.

[Karl, 2015-12-15 17:33:10]

lgtm

https://codereview.chromium.org/1523873003/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1523873003/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1794: << "sy";
Slight inconsistency here? dmb is the the opcode. In other places you did not
separate tables between opcodes and arguments.

[Jim Stichnoth, 2015-12-16 14:05:12]

https://codereview.chromium.org/1523873003/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1523873003/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1794: << "sy";
On 2015/12/15 17:33:10, Karl wrote:
> Slight inconsistency here? dmb is the the opcode. In other places you did not
> separate tables between opcodes and arguments.

Done.

[Jim Stichnoth, 2015-12-16 14:18:02]

Description was changed from

==========
Subzero: Separate "\t" from "opcode" in asm emission.

Instead of output like this:
  Str << "\tmov\t" << ...
we prefer to use string concatenation:
  Str << "\t" "mov\t" << ...

That way, "git grep -w mov" can be used for more precise pattern matching.

BUG= none
==========

to

==========
Subzero: Separate "\t" from "opcode" in asm emission.

Instead of output like this:
  Str << "\tmov\t" << ...
we prefer to use string concatenation:
  Str << "\t" "mov\t" << ...

That way, "git grep -w mov" can be used for more precise pattern matching.

BUG= none
R=kschimpf@google.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2015-12-16 14:18:03]

Committed patchset #3 (id:40001) manually as
6106df803dbfd6f1cdf277bacb5437c567ec607f (presubmit successful).