third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp - Issue 1523843004: Add support for new CSS ::slotted() pseudo element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

Issue 1523843004: Add support for new CSS ::slotted() pseudo element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tentative fix for crash / querySelector test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp b/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

index 0f993d87aea9d8f88aac90c8dc41b76c2ed396b3..08398319f27fbeb98c6ddfe6721b45b696955f2f 100644

--- a/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp

@@ -278,6 +278,11 @@ bool SharedStyleFinder::canShareStyleWithElement(Element& candidate) const

return false;

}

+ // TODO(kochi): Investigate cases when assigned slots can share styles.

+ // TODO(kochi): Figure out better way to check if an element is slotted.

+ if (element().assignedSlotForBinding())

+ return false;

return true;

}