third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-css-text.html - Issue 1523843004: Add support for new CSS ::slotted() pseudo element

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-css-text.html

Issue 1523843004: Add support for new CSS ::slotted() pseudo element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tentative fix for crash / querySelector test Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element.html ('K') | « third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element.html ('k') | third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change.html » ('j') | third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-shared-style.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src='../../../resources/testharness.js'></script>

	3 <script src='../../../resources/testharnessreport.js'></script>

	4 <style id="style1">

	5 .foo::slotted(div) .bar::before { display: block; }
	rune 2016/01/09 01:15:36 This should be invalid, I think. ::slotted should This should be invalid, I think. ::slotted should only be allowed as the last selector of the last compound. You don't need to fix in it this CL since this is a general problem with our selector parsing, but add a comment that it should be invalid, but currently isn't. kochi 2016/01/13 07:49:31 Done. Show quoted text On 2016/01/09 01:15:36, rune wrote: > This should be invalid, I think. ::slotted should only be allowed as the last > selector of the last compound. You don't need to fix in it this CL since this is > a general problem with our selector parsing, but add a comment that it should be > invalid, but currently isn't. Done.
	6 ::slotted { display: block; } /* invalid - no parameter */

	7 ::slotted() { display: block; } /* invalid - empty parameter */

	8 slot::slotted(div, div) { display: block; } /* invalid - selector list */

	9 slot::slotted(div div) { display: block; } /* invalid - complex selector (combin ator) */

	10 slot::slotted(.green) { color: green; }

	11 slot::slotted(#green) { color: green; }

	12 slot::slotted([green=green]) { color: green; }

	13 slot::slotted(div.green) { color: green; }

	14 ::slotted() { color: blue; }

	15 .foo::slotted(*) { color: blue; }

	16 #id::slotted(*) { color: blue; }

	17 [attr=foo]::slotted(*) { color: blue; }

	18 span::slotted() { color: blue; } / never matches, but valid */
	rune 2016/01/09 01:15:36 could you add a case or two where you have a compo could you add a case or two where you have a compound preceding the ::slotted with a combinator like "div ::slotted(#x)", "div + ::slotted(.x)"? kochi 2016/01/13 07:49:31 Done. Show quoted text On 2016/01/09 01:15:36, rune wrote: > could you add a case or two where you have a compound preceding the ::slotted > with a combinator like "div ::slotted(#x)", "div + ::slotted(.x)"? Done.
	19 </style>

	20 <script>

	21 'use strict';

	22 test(() => {

	23 assert_equals(document.getElementById('style1').sheet.cssRules.item(0).cssText ,

	24 ".foo::slotted(div) .bar::before { display: block; }");

	25 assert_equals(document.getElementById('style1').sheet.cssRules.item(1).cssText ,

	26 "slot::slotted(.green) { color: green; }");

	27 assert_equals(document.getElementById('style1').sheet.cssRules.item(2).cssText ,

	28 "slot::slotted(#green) { color: green; }");

	29 assert_equals(document.getElementById('style1').sheet.cssRules.item(3).cssText ,

	30 "slot::slotted([green=\"green\"]) { color: green; }");

	31 assert_equals(document.getElementById('style1').sheet.cssRules.item(4).cssText ,

	32 "slot::slotted(div.green) { color: green; }");

	33 assert_equals(document.getElementById('style1').sheet.cssRules.item(5).cssText ,

	34 "::slotted() { color: blue; }");
	rune 2016/01/09 01:15:36 Why does the serialization contain the (first) '' Why does the serialization contain the (first) '' selector here? kochi 2016/01/13 07:49:31 Because we add an implicit universal type selector Show quoted text On 2016/01/09 01:15:36, rune wrote: > Why does the serialization contain the (first) '' selector here? Because we add an implicit universal type selector before ::slotted(). rune* 2016/01/13 10:02:30 Implicit means we shouldn't need to serialize it, Show quoted text On 2016/01/13 07:49:31, kochi wrote: > On 2016/01/09 01:15:36, rune wrote: > > Why does the serialization contain the (first) '' selector here? > > Because we add an implicit universal type selector before ::slotted(). Implicit means we shouldn't need to serialize it, but I see that this is just exposing the same bug we have with ::content and ::-webkit-. I've coincidentally fixed that in https://codereview.chromium.org/1574323003/
	35 assert_equals(document.getElementById('style1').sheet.cssRules.item(6).cssText ,

	36 ".foo::slotted(*) { color: blue; }");

	37 assert_equals(document.getElementById('style1').sheet.cssRules.item(7).cssText ,

	38 "#id::slotted(*) { color: blue; }");

	39 assert_equals(document.getElementById('style1').sheet.cssRules.item(8).cssText ,

	40 "[attr=\"foo\"]::slotted(*) { color: blue; }");

	41 assert_equals(document.getElementById('style1').sheet.cssRules.item(9).cssText ,

	42 "span::slotted(*) { color: blue; }");

	43 }, "Test for cssText of '::slotted' rule.");

	44 </script>

OLD	NEW