Add more compiler timeline durations

Add more compiler timeline durations

All phases of unoptimized and optimized compilation are now on the timeline.

R=fschneider@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/27d05fc98a90b82757c0ca0ecff8007cee56520b

[Cutch, 2015-12-14 22:03:25]

Description was changed from

==========
Add more compiler timeline durations

BUG=
==========

to

==========
Add more compiler timeline durations

- BuildFlowGraph
- BlockScheduler
- CompileGraph
- FinalizeCompilation
==========

[Cutch, 2015-12-14 22:03:25]

johnmccutchan@google.com changed reviewers:
+ fschneider@google.com, rmacnak@google.com

[Cutch, 2015-12-14 22:03:43]

Description was changed from

==========
Add more compiler timeline durations

- BuildFlowGraph
- BlockScheduler
- CompileGraph
- FinalizeCompilation
==========

to

==========
Add more compiler timeline durations

- BuildFlowGraph
- BlockScheduler
- CompileGraph
- FinalizeCompilation
- InitCompiler
- ParseFunction
==========

[Florian Schneider, 2015-12-15 09:47:27]

lgtm

https://codereview.chromium.org/1523833003/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1523833003/diff/1/runtime/vm/compiler.cc#newc...
runtime/vm/compiler.cc:774: }
Why just measure this phase? I think the whole optimizations phase from "Before
Optimizations" to here would be better suitable.

https://codereview.chromium.org/1523833003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1523833003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:816: void Parser::ParseClass(const Class& cls) {
Maybe also add a timeline event for ParseClass?

[Cutch, 2015-12-15 16:59:26]

PTAL

https://codereview.chromium.org/1523833003/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1523833003/diff/1/runtime/vm/compiler.cc#newc...
runtime/vm/compiler.cc:774: }
On 2015/12/15 09:47:27, Florian Schneider wrote:
> Why just measure this phase? I think the whole optimizations phase from
"Before
> Optimizations" to here would be better suitable.

Done.

https://codereview.chromium.org/1523833003/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/1523833003/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:816: void Parser::ParseClass(const Class& cls) {
On 2015/12/15 09:47:27, Florian Schneider wrote:
> Maybe also add a timeline event for ParseClass?

Done.

[Cutch, 2015-12-15 16:59:54]

Description was changed from

==========
Add more compiler timeline durations

- BuildFlowGraph
- BlockScheduler
- CompileGraph
- FinalizeCompilation
- InitCompiler
- ParseFunction
==========

to

==========
Add more compiler timeline durations

All phases of unoptimized and optimized compilation are now on the timeline.
==========

[Florian Schneider, 2015-12-15 17:15:35]

Lgtm. We may remove even more. I think the most important are all optimization
passes, inlining, register allocation, CSE.

https://codereview.chromium.org/1523833003/diff/1/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1523833003/diff/1/runtime/vm/compiler.cc#newc...
runtime/vm/compiler.cc:774: }
On 2015/12/15 16:59:25, Cutch wrote:
> On 2015/12/15 09:47:27, Florian Schneider wrote:
> > Why just measure this phase? I think the whole optimizations phase from
> "Before
> > Optimizations" to here would be better suitable.
> 
> Done.

Oh ok - that's more than I expected. I thought one aggregate scope for all
optimization passes would be enough - maybe split out inlining, register
allocation.
This works as well, but note that some of the phases are really really short
(like Canonicalize), so I would remove those.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:608: "Canonicalize");
Remove scope for canonicalize.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:647: TimelineDurationScope tds2(thread,
Remove this scope.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:671: TimelineDurationScope tds2(thread,
Merge with previous scope.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:680: 
ComputeBlockEffects, CSE, LICM in one scope.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:775: TimelineDurationScope tds2(thread,
Remove this scope.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:790: TimelineDurationScope tds2(thread,
Remove this scope.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:826: TimelineDurationScope tds2(thread,
Remove this scope.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:853: TimelineDurationScope tds2(thread,
Remove this scope.

[rmacnak, 2015-12-15 17:24:37]

I'd also add a scope for DartCompilationPipeline::ParseFunction.

lgtm

[Cutch, 2015-12-15 17:51:50]

Description was changed from

==========
Add more compiler timeline durations

All phases of unoptimized and optimized compilation are now on the timeline.
==========

to

==========
Add more compiler timeline durations

All phases of unoptimized and optimized compilation are now on the timeline.

R=fschneider@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/27d05fc98a90b82757c0ca0ecff8007cee56520b
==========

[Cutch, 2015-12-15 17:51:51]

Committed patchset #3 (id:40001) manually as
27d05fc98a90b82757c0ca0ecff8007cee56520b (presubmit successful).

[Cutch, 2015-12-15 17:51:56]

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:608: "Canonicalize");
On 2015/12/15 17:15:35, Florian Schneider wrote:
> Remove scope for canonicalize.

Done.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:647: TimelineDurationScope tds2(thread,
On 2015/12/15 17:15:35, Florian Schneider wrote:
> Remove this scope.

Done.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:671: TimelineDurationScope tds2(thread,
On 2015/12/15 17:15:35, Florian Schneider wrote:
> Merge with previous scope.

Done.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:680: 
On 2015/12/15 17:15:35, Florian Schneider wrote:
> ComputeBlockEffects, CSE, LICM in one scope.

Done.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:775: TimelineDurationScope tds2(thread,
On 2015/12/15 17:15:35, Florian Schneider wrote:
> Remove this scope.

Done.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:790: TimelineDurationScope tds2(thread,
On 2015/12/15 17:15:35, Florian Schneider wrote:
> Remove this scope.

Done.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:826: TimelineDurationScope tds2(thread,
On 2015/12/15 17:15:35, Florian Schneider wrote:
> Remove this scope.

Done.

https://codereview.chromium.org/1523833003/diff/20001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:853: TimelineDurationScope tds2(thread,
On 2015/12/15 17:15:35, Florian Schneider wrote:
> Remove this scope.

Done.