Move justify-content/align-content properties into CSSPropertyParser

Move justify-content/align-content properties into CSSPropertyParser

Move justify-content/align-content property handling from LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
Committed: https://crrev.com/c6b401106b4801fce0e62877db673e913b67b11d
Cr-Commit-Position: refs/heads/master@{#372593}

[rwlbuis, 2015-12-17 20:58:58]

Description was changed from

==========
justify-content

BUG=
==========

to

==========
Move justify-content/align-content properties into CSSPropertyParser

Move justify-content/align-content property handling from
LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

[rmistry, 2016-01-19 12:09:46]

Running the 'CQ dry run' will end up selecting the trybots relevant to your
change. Selecting all trybots in Rietveld will trigger trybots in different
projects which will fail to apply the patch and not be relevant to your change.


On 2015/12/17 20:58:58, rwlbuis wrote:
> Description was changed from
> 
> ==========
> justify-content
> 
> BUG=
> ==========
> 
> to
> 
> ==========
> Move justify-content/align-content properties into CSSPropertyParser
> 
> Move justify-content/align-content property handling from
> LegacyCSSPropertyParser
> into CSSPropertyParser.
> 
> BUG=499780
> ==========

[rwlbuis, 2016-01-19 12:34:34]

On 2016/01/19 12:09:46, rmistry wrote:
> Running the 'CQ dry run' will end up selecting the trybots relevant to your
> change. Selecting all trybots in Rietveld will trigger trybots in different
> projects which will fail to apply the patch and not be relevant to your
change.

Thanks, I was as usual trying to select linux_blink_rel and hit update, not sure
why
so much was triggered. I'll try to be more careful in the future.

[rwlbuis, 2016-01-28 23:23:06]

rob.buis@samsung.com changed reviewers:
+ timloh@chromium.org

[rwlbuis, 2016-01-28 23:23:06]

PTAL. Note that these days LegacyCSSPropertyParser.cpp < CSSPropertyParser.cpp
:)

[Timothy Loh, 2016-02-01 00:30:58]

lgtm

https://codereview.chromium.org/1523803002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp (right):

https://codereview.chromium.org/1523803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3161: if
(identMatches<CSSValueSpaceBetween, CSSValueSpaceAround, CSSValueSpaceEvenly,
CSSValueStretch>(range.peek().id())) {
Maybe nicer if we just write CSSValueID id = range.peek().id() at the top of the
loop, and then range.consumeIncludingWhitespace() at the bottom of the loop.
Less repetition.

https://codereview.chromium.org/1523803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp:3179: //
<content-position> ( <content-distribution> || <content-position> ).
This comment confused me, since I thought the second line of the comment was
supposed to be the grammar (and not just the parenthesised portion). Maybe it's
clearer to just drop the parenthesised grammar.

[rwlbuis, 2016-02-01 02:20:59]

The CQ bit was checked by rob.buis@samsung.com

[rwlbuis, 2016-02-01 02:21:00]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1523803002/#ps140001
(title: "Patch for landing")

[commit-bot: I haz the power, 2016-02-01 02:21:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523803002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523803002/140001

[commit-bot: I haz the power, 2016-02-01 03:37:24]

Description was changed from

==========
Move justify-content/align-content properties into CSSPropertyParser

Move justify-content/align-content property handling from
LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

to

==========
Move justify-content/align-content properties into CSSPropertyParser

Move justify-content/align-content property handling from
LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

[commit-bot: I haz the power, 2016-02-01 03:37:25]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-02-01 03:38:56]

Description was changed from

==========
Move justify-content/align-content properties into CSSPropertyParser

Move justify-content/align-content property handling from
LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780
==========

to

==========
Move justify-content/align-content properties into CSSPropertyParser

Move justify-content/align-content property handling from
LegacyCSSPropertyParser
into CSSPropertyParser.

BUG=499780

Committed: https://crrev.com/c6b401106b4801fce0e62877db673e913b67b11d
Cr-Commit-Position: refs/heads/master@{#372593}
==========

[commit-bot: I haz the power, 2016-02-01 03:38:57]

Patchset 8 (id:??) landed as
https://crrev.com/c6b401106b4801fce0e62877db673e913b67b11d
Cr-Commit-Position: refs/heads/master@{#372593}