Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1523793002: Switch fragment coordinate to 'highp' to fix various broken GMs. (Closed)

Created:
5 years ago by ethannicholas
Modified:
5 years ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch fragment coordinate to 'highp' to fix various broken GMs. BUG=skia:4693 Committed: https://skia.googlesource.com/skia/+/1cbb5ea0a07255bcc0b8351ddf1fc84f50887aef

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ethannicholas
5 years ago (2015-12-14 18:41:12 UTC) #2
bsalomon
lgtm
5 years ago (2015-12-14 18:44:41 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523793002/20001
5 years ago (2015-12-14 19:15:32 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-14 19:36:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523793002/20001
5 years ago (2015-12-14 19:37:15 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-14 19:38:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1cbb5ea0a07255bcc0b8351ddf1fc84f50887aef

Powered by Google App Engine
This is Rietveld 408576698