Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1708)

Unified Diff: chrome/browser/chromeos/login/signin/oauth2_login_manager.cc

Issue 1523743003: Always fire refresh tokens loaded on ChromeOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: insert bug no Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/signin/oauth2_login_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
diff --git a/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc b/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
index 8b79b2f5b4ab88ca845fc03079362ef02997f7ef..8a817cd74b7c51826b2da7dc59418a6377274374 100644
--- a/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
+++ b/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
@@ -100,6 +100,7 @@ void OAuth2LoginManager::RestoreSessionFromSavedTokens() {
const std::string& primary_account_id = GetPrimaryAccountId();
if (token_service->RefreshTokenIsAvailable(primary_account_id)) {
VLOG(1) << "OAuth2 refresh token is already loaded.";
+ FireRefreshTokensLoaded();
VerifySessionCookies();
} else {
VLOG(1) << "Loading OAuth2 refresh token from database.";
@@ -195,11 +196,17 @@ void OAuth2LoginManager::UpdateCredentials(const std::string& account_id) {
DCHECK(!refresh_token_.empty());
// |account_id| is assumed to be already canonicalized if it's an email.
GetTokenService()->UpdateCredentials(account_id, refresh_token_);
+ FireRefreshTokensLoaded();
FOR_EACH_OBSERVER(Observer, observer_list_,
OnNewRefreshTokenAvaiable(user_profile_));
}
+void OAuth2LoginManager::FireRefreshTokensLoaded() {
+ // TODO(570218): Figure out the right way to plumb this.
+ GetTokenService()->LoadCredentials(std::string());
+}
+
void OAuth2LoginManager::OnRefreshTokenResponse(
const std::string& access_token,
int expires_in_seconds) {
« no previous file with comments | « chrome/browser/chromeos/login/signin/oauth2_login_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698