Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1523733003: SkPreConfig.h: Allow defined(__unix__) to imply SK_BUILD_FOR_UNIX (Closed)

Created:
5 years ago by Mark Seaborn
Modified:
5 years ago
Reviewers:
mtklein, mtklein_C, reed1
CC:
Petr Hosek, reviews_skia.org, Sean Klein
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPreConfig.h: Allow defined(__unix__) to imply SK_BUILD_FOR_UNIX This is more general than checking for __linux, __FreeBSD__, etc. (In principle we could remove some of the existing checks such as __FreeBSD__, but I have not tried that so far.) In particular, it allows Skia to build with the NaCl or PNaCl toolchains, which is something we would like for Mojo. BUG=https://github.com/domokit/mojo/issues/431 TEST=none Committed: https://skia.googlesource.com/skia/+/19b0420e877d3e27d5315d8a539e671cf2b479eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M include/core/SkPreConfig.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Mark Seaborn
5 years ago (2015-12-14 23:53:02 UTC) #3
mtklein
lgtm
5 years ago (2015-12-15 15:20:55 UTC) #5
reed1
lgtm
5 years ago (2015-12-15 15:36:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523733003/1
5 years ago (2015-12-15 15:38:25 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-15 15:52:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/19b0420e877d3e27d5315d8a539e671cf2b479eb

Powered by Google App Engine
This is Rietveld 408576698