Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: components/arc/test/fake_app_instance.h

Issue 1523643002: arc-bridge: Move most methods to Mojo interfaces (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Addressed feedback Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/input/arc_input_bridge_impl.cc ('k') | components/arc/test/fake_app_instance.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/test/fake_app_instance.h
diff --git a/components/arc/test/fake_arc_bridge_service.h b/components/arc/test/fake_app_instance.h
similarity index 55%
copy from components/arc/test/fake_arc_bridge_service.h
copy to components/arc/test/fake_app_instance.h
index ef4e20d0c8fa8a3e6f23e114ac3264a8ac6cc0bf..50c5c4d0084e122448e464a76bef4641010458d5 100644
--- a/components/arc/test/fake_arc_bridge_service.h
+++ b/components/arc/test/fake_app_instance.h
@@ -2,29 +2,25 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef COMPONENTS_ARC_TEST_FAKE_ARC_BRIDGE_SERVICE_H_
-#define COMPONENTS_ARC_TEST_FAKE_ARC_BRIDGE_SERVICE_H_
+#ifndef COMPONENTS_ARC_iTEST_FAKE_APP_INSTANCE_H_
+#define COMPONENTS_ARC_iTEST_FAKE_APP_INSTANCE_H_
xiyuan 2015/12/16 17:17:51 nit: fix typo, iTEST-> TEST
Luis Héctor Chávez 2015/12/16 17:58:34 Done.
#include <string>
#include <vector>
-#include "base/macros.h"
#include "base/memory/scoped_vector.h"
-#include "components/arc/arc_bridge_service.h"
+#include "components/arc/common/app.mojom.h"
+#include "mojo/public/cpp/bindings/binding.h"
namespace arc {
-class FakeArcBridgeService : public ArcBridgeService {
+class FakeAppInstance : public AppInstance {
public:
class Request {
public:
Request(const std::string& package, const std::string& activity)
- : package_(package),
- activity_(activity) {
- }
-
- ~Request() {
- }
+ : package_(package), activity_(activity) {}
+ ~Request() {}
const std::string& package() const { return package_; }
@@ -46,12 +42,8 @@ class FakeArcBridgeService : public ArcBridgeService {
IconRequest(const std::string& package,
const std::string& activity,
ScaleFactor scale_factor)
- : Request(package, activity),
- scale_factor_(scale_factor) {
- }
-
- ~IconRequest() {
- }
+ : Request(package, activity), scale_factor_(scale_factor) {}
+ ~IconRequest() {}
int scale_factor() const { return scale_factor_; }
@@ -61,24 +53,27 @@ class FakeArcBridgeService : public ArcBridgeService {
DISALLOW_COPY_AND_ASSIGN(IconRequest);
};
- FakeArcBridgeService();
- ~FakeArcBridgeService() override;
-
- // arc::ArcBridgeService
- void DetectAvailability() override;
- void HandleStartup() override;
- void Shutdown() override;
- bool RegisterInputDevice(const std::string& name,
- const std::string& device_type,
- base::ScopedFD fd) override;
- bool RefreshAppList() override;
- bool LaunchApp(const std::string& package,
- const std::string& activity) override;
- bool RequestAppIcon(const std::string& package,
- const std::string& activity,
+ explicit FakeAppInstance(AppHost* app_host);
+ ~FakeAppInstance() override;
+
+ void Bind(mojo::InterfaceRequest<AppInstance> interface_request) {
+ binding_.Bind(std::move(interface_request));
+ }
+
+ // AppInstance overrides:
+ void Init(AppHostPtr host_ptr) override {}
+ void RefreshAppList() override;
+ void LaunchApp(const mojo::String& package,
+ const mojo::String& activity) override;
+ void RequestAppIcon(const mojo::String& package,
+ const mojo::String& activity,
ScaleFactor scale_factor) override;
- bool SendNotificationEventToAndroid(const std::string& key,
- ArcNotificationEvent event) override;
+
+ // Methods to reply messages.
+ void SendRefreshAppList(const std::vector<AppInfo>& apps);
+ bool GenerateAndSendIcon(const AppInfo& app,
+ ScaleFactor scale_factor,
+ std::string* png_data_as_string);
int refresh_app_list_count() const { return refresh_app_list_count_; }
@@ -90,30 +85,18 @@ class FakeArcBridgeService : public ArcBridgeService {
return icon_requests_;
}
- void SetReady();
-
- void SetStopped();
-
- bool HasObserver(const Observer* observer);
- bool HasAppObserver(const AppObserver* observer);
-
- void SendRefreshAppList(const std::vector<AppInfo>& apps);
-
- bool GenerateAndSendIcon(const AppInfo& app,
- ScaleFactor scale_factor,
- std::string* png_data);
-
private:
+ // Mojo endpoints.
+ mojo::Binding<AppInstance> binding_;
+ AppHost* app_host_;
// Number of RefreshAppList calls.
int refresh_app_list_count_ = 0;
// Keeps information about launch requests.
ScopedVector<Request> launch_requests_;
// Keeps information about icon load requests.
ScopedVector<IconRequest> icon_requests_;
-
- DISALLOW_COPY_AND_ASSIGN(FakeArcBridgeService);
};
} // namespace arc
-#endif // COMPONENTS_ARC_TEST_FAKE_ARC_BRIDGE_SERVICE_H_
+#endif // COMPONENTS_ARC_iTEST_FAKE_APP_INSTANCE_H_
« no previous file with comments | « components/arc/input/arc_input_bridge_impl.cc ('k') | components/arc/test/fake_app_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698