Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: components/arc/arc_bridge_service_impl.h

Issue 1523643002: arc-bridge: Move most methods to Mojo interfaces (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Fixed unit tests Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/arc_bridge_service_impl.h
diff --git a/components/arc/arc_bridge_service_impl.h b/components/arc/arc_bridge_service_impl.h
index 90e9b92e49757357e08a38bce2207e1ccdaeda47..9810b24b1b0f0ea57318f60b66f9811c31b79582 100644
--- a/components/arc/arc_bridge_service_impl.h
+++ b/components/arc/arc_bridge_service_impl.h
@@ -36,25 +36,6 @@ class ArcBridgeServiceImpl : public ArcBridgeService,
void Shutdown() override;
- bool RegisterInputDevice(const std::string& name,
- const std::string& device_type,
- base::ScopedFD fd) override;
-
- bool SendNotificationEventToAndroid(const std::string& key,
- ArcNotificationEvent event) override;
-
- // Requests to refresh an app list.
- bool RefreshAppList() override;
-
- // Requests to launch an app.
- bool LaunchApp(const std::string& package,
- const std::string& activity) override;
-
- // Requests to load an icon of specific scale_factor.
- bool RequestAppIcon(const std::string& package,
- const std::string& activity,
- ScaleFactor scale_factor) override;
-
private:
friend class ArcBridgeTest;
FRIEND_TEST_ALL_PREFIXES(ArcBridgeTest, Basic);
@@ -69,25 +50,14 @@ class ArcBridgeServiceImpl : public ArcBridgeService,
// Stops the running instance.
void StopInstance();
- // Called when the instance has reached a boot phase
- void OnInstanceBootPhase(InstanceBootPhase phase) override;
- // Handler for ArcInstanceHostMsg_NotificationPosted message.
- void OnNotificationPosted(ArcNotificationDataPtr data) override;
- // Handler for ArcInstanceHostMsg_NotificationRemoved message.
- void OnNotificationRemoved(const mojo::String& key) override;
-
- // Called whenever ARC sends information about available apps.
- void OnAppListRefreshed(mojo::Array<arc::AppInfoPtr> apps) override;
-
- // Called whenever ARC sends app icon data for specific scale factor.
- void OnAppIcon(const mojo::String& package,
- const mojo::String& activity,
- ScaleFactor scale_factor,
- mojo::Array<uint8_t> icon_png_data) override;
-
- // Called when the instance requests wake lock services
- void OnAcquireDisplayWakeLock(DisplayWakeLockType type) override;
- void OnReleaseDisplayWakeLock(DisplayWakeLockType type) override;
+ // ArcBridgeHost:
+ void OnAppInstanceReady(AppInstancePtr app_ptr) override;
+ void OnInputInstanceReady(InputInstancePtr input_ptr) override;
+ void OnNotificationsInstanceReady(
+ NotificationsInstancePtr notifications_ptr) override;
+ void OnPowerInstanceReady(PowerInstancePtr power_ptr) override;
+ void OnProcessListInstanceReady(
+ ProcessListInstancePtr process_list_ptr) override;
// ArcBridgeBootstrap::Delegate:
void OnConnectionEstablished(ArcBridgeInstancePtr instance) override;

Powered by Google App Engine
This is Rietveld 408576698