Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: components/arc/arc_bridge_service_impl.h

Issue 1523643002: arc-bridge: Move most methods to Mojo interfaces (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@master
Patch Set: Rebased to ToT Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc/arc_bridge_service.cc ('k') | components/arc/arc_bridge_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/arc_bridge_service_impl.h
diff --git a/components/arc/arc_bridge_service_impl.h b/components/arc/arc_bridge_service_impl.h
index 969e0cb7792c4966c08de65dbcf39709878b1974..d0de3e3a6343a2d56ea6409fdce7b75f335947ca 100644
--- a/components/arc/arc_bridge_service_impl.h
+++ b/components/arc/arc_bridge_service_impl.h
@@ -24,7 +24,6 @@ namespace arc {
// Real IPC based ArcBridgeService that is used in production.
class ArcBridgeServiceImpl : public ArcBridgeService,
- public ArcBridgeHost,
public ArcBridgeBootstrap::Delegate {
public:
explicit ArcBridgeServiceImpl(scoped_ptr<ArcBridgeBootstrap> bootstrap);
@@ -36,33 +35,6 @@ class ArcBridgeServiceImpl : public ArcBridgeService,
void Shutdown() override;
- bool RegisterInputDevice(const std::string& name,
- const std::string& device_type,
- base::ScopedFD fd) override;
-
- bool SendBroadcast(const std::string& action,
- const std::string& package,
- const std::string& clazz,
- const base::DictionaryValue& extras) override;
-
- bool SendNotificationEventToAndroid(const std::string& key,
- ArcNotificationEvent event) override;
-
- // Requests to refresh an app list.
- bool RefreshAppList() override;
-
- // Requests to launch an app.
- bool LaunchApp(const std::string& package,
- const std::string& activity) override;
-
- // Requests to load an icon of specific scale_factor.
- bool RequestAppIcon(const std::string& package,
- const std::string& activity,
- ScaleFactor scale_factor) override;
-
- // Requests ARC process list.
- bool RequestProcessList() override;
-
private:
friend class ArcBridgeTest;
FRIEND_TEST_ALL_PREFIXES(ArcBridgeTest, Basic);
@@ -77,30 +49,6 @@ class ArcBridgeServiceImpl : public ArcBridgeService,
// Stops the running instance.
void StopInstance();
- // Called when the instance has reached a boot phase
- void OnInstanceBootPhase(InstanceBootPhase phase) override;
- // Handler for ArcInstanceHostMsg_NotificationPosted message.
- void OnNotificationPosted(ArcNotificationDataPtr data) override;
- // Handler for ArcInstanceHostMsg_NotificationRemoved message.
- void OnNotificationRemoved(const mojo::String& key) override;
-
- // Called whenever ARC sends information about available apps.
- void OnAppListRefreshed(mojo::Array<arc::AppInfoPtr> apps) override;
-
- // Called whenever ARC sends app icon data for specific scale factor.
- void OnAppIcon(const mojo::String& package,
- const mojo::String& activity,
- ScaleFactor scale_factor,
- mojo::Array<uint8_t> icon_png_data) override;
-
- // Called when the latest process list is reported from ARC.
- void OnUpdateProcessList(
- mojo::Array<RunningAppProcessInfoPtr> processes_ptr) override;
-
- // Called when the instance requests wake lock services
- void OnAcquireDisplayWakeLock(DisplayWakeLockType type) override;
- void OnReleaseDisplayWakeLock(DisplayWakeLockType type) override;
-
// ArcBridgeBootstrap::Delegate:
void OnConnectionEstablished(ArcBridgeInstancePtr instance) override;
void OnStopped() override;
« no previous file with comments | « components/arc/arc_bridge_service.cc ('k') | components/arc/arc_bridge_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698