Chromium Code Reviews
DescriptionWebInbandTextTrack should be deallocated by caller
An object that inherits from WebInbandTextTrack is created
on the Chromium side of the WebKit interface, and handed to
the InbandTextTrackPrivateImpl (via its constructor). The
InbandTextTrackPrivateImpl object currently assumes
ownership of the pointer, and so the
InbandTextTrackPrivateImpl object deallocates the
WebInbandTextTrack object (via its destructor).
However, this means that abstractions on the Chromium side
of the WebKit interface can potentially outlive the
abstractions on the WebKit side on which they depend.
To ameliorate such lifetime issues, the responsibility for
deallocating the WebInbandTextTrack object was moved to the
Chromium side, hence the InbandTextTrackPrivateImpl object
is no longer required to deallocate that object.
Note that the this change does not have a dedicated unit
test, because no code exists that actually calls this code.
These changes to WebKit are a prerequisite for the change
that adds support for inband text track rendering to Chrome,
as enunciated here:
https://chromiumcodereview.appspot.com/13419002/
The requisite infrastructure for testing all of the changes
in toto will be included when that cited change is
committed.
BUG=230708
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150686
Patch Set 1 #
Messages
Total messages: 6 (0 generated)
|
||||||||||||||||||||||||||||