chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc - Issue 1523593002: Add an option in language settings for activating the IME menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

Issue 1523593002: Add an option in language settings for activating the IME menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add enable-ime-menu flag Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/language_options.js ('K') | « chrome/browser/resources/options/language_options.js ('k') | chrome/chrome_browser_chromeos.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

index 3a05c24ea120ecebbdaf5bf074011f297aa6dacf..cfd131fd9360fca8db36f5a824ee3b9f0b7c6e73 100644

--- a/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc

@@ -84,6 +84,13 @@ void CrosLanguageOptionsHandler::GetLocalizedValues(

localized_strings->SetString("noInputMethods",

l10n_util::GetStringUTF16(

IDS_OPTIONS_SETTINGS_LANGUAGES_NO_INPUT_METHODS));

+ localized_strings->SetString(

+ "activateImeMenu", l10n_util::GetStringUTF16(

michaelpg 2016/01/04 16:37:36 nit: use consistent formatting with the above line

Azure Wei 2016/01/05 06:48:03 Done.

+ IDS_OPTIONS_SETTINGS_LANGUAGES_ACTIVATE_IME_MENU));

+ localized_strings->SetString(

+ "activateImeMenuDesc",

+ l10n_util::GetStringUTF16(

+ IDS_OPTIONS_SETTINGS_LANGUAGES_ACTIVATE_IME_MENU_DESCRIPTION));

// GetSupportedInputMethods() never returns NULL.

localized_strings->Set("languageList", GetAcceptLanguageList().release());