Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/resources/options/language_options.js

Issue 1523593002: Add an option in language settings for activating the IME menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove pref kLangugaeImeMenuFlagEnabled Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_options.js
diff --git a/chrome/browser/resources/options/language_options.js b/chrome/browser/resources/options/language_options.js
index 0975c939746c1cd47a6d5cbc69047764030aa967..a690ae4fb74772a2ff3c5337921ccebaf82bb91f 100644
--- a/chrome/browser/resources/options/language_options.js
+++ b/chrome/browser/resources/options/language_options.js
@@ -66,6 +66,13 @@ cr.define('options', function() {
*/
var ENABLE_TRANSLATE = 'translate.enabled';
+ /**
+ * The preference is a boolean that activates/deactivates IME menu on shelf.
+ * @type {string}
+ * @const
+ */
+ var ACTIVATE_IME_MENU_PREF = 'settings.language.ime_menu_activated';
+
/////////////////////////////////////////////////////////////////////////////
// LanguageOptions class:
@@ -270,6 +277,15 @@ cr.define('options', function() {
// Public session users cannot change the locale.
if (cr.isChromeOS && UIAccountTweaks.loggedInAsPublicAccount())
$('language-options-ui-language-section').hidden = true;
+
+ if (loadTimeData.getBoolean('enableLanguageOptionsImeMenu')) {
+ $('language-options-ime-menu-template').hidden = false;
+ }
+
+ // Listen to check on 'activate-ime-menu' checkbox
+ var checkboxImeMenu = $('activate-ime-menu');
+ checkboxImeMenu.addEventListener('click',
+ this.handleActivateImeMenuCheckboxClick_.bind(this));
},
/**
@@ -1416,6 +1432,17 @@ cr.define('options', function() {
return main;
},
+
+ /**
+ * Handles activate-ime-menu checkbox's click event.
+ * @param {Event} e Click event.
+ * @private
+ */
+ handleActivateImeMenuCheckboxClick_: function(e) {
+ var checkbox = e.target;
+ Preferences.setBooleanPref(ACTIVATE_IME_MENU_PREF,
+ checkbox.checked, true);
stevenjb 2016/01/05 17:31:13 The preferred format is to align the arguments, i.
Azure Wei 2016/01/07 03:04:57 Done.
+ },
};
/**
« no previous file with comments | « chrome/browser/resources/options/language_options.html ('k') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698