Add an option in language settings for activating the IME menu.

chrome/browser/resources/options/language_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(kochi): Generalize the notification as a component and put it
 // in js/cr/ui/notification.js .
 
 cr.define('options', function() {
   /** @const */ var Page = cr.ui.pageManager.Page;
   /** @const */ var PageManager = cr.ui.pageManager.PageManager;
@@ skipping 48 matching lines @@
    */
   var SPELL_CHECK_DICTIONARIES_PREF = 'spellcheck.dictionaries';
 
   /**
    * The preference that indicates if the Translate feature is enabled.
    * @type {string}
    * @const
    */
   var ENABLE_TRANSLATE = 'translate.enabled';
 
+  /**
+   * The preference is a boolean indicates whether the 'enable-ime-menu' flag is
+   * enabled or disabled
+   * @type {string}
+   * @const
+   */
+  var ENABLE_IME_MENU_FLAG_PREF = 'settings.language.ime_menu_flag_enabled';

[michaelpg, 2016/01/04 16:37:36]

i think we usually set flag info via loadTimeData using a boolean in
GetLocalizedValues

[stevenjb, 2016/01/04 17:58:10]

Correct, e.g. see enableTimeZoneTrackingOption

[Azure Wei, 2016/01/05 06:48:03]

Done.

[Azure Wei, 2016/01/05 06:48:03]

Done.

+
+  /**
+   * The preference is a boolean that activates/deactivates IME menu on shelf.
+   * @type {string}
+   * @const
+   */
+  var ACTIVATE_IME_MENU_PREF = 'settings.language.ime_menu_activated';
+
   /////////////////////////////////////////////////////////////////////////////
   // LanguageOptions class:
 
   /**
    * Encapsulated handling of ChromeOS language options page.
    * @constructor
    * @extends {cr.ui.pageManager.Page}
    */
   function LanguageOptions(model) {
     Page.call(this, 'languages',
@@ skipping 116 matching lines @@
 
       Preferences.getInstance().addEventListener(
           TRANSLATE_BLOCKED_LANGUAGES_PREF,
           this.handleTranslateBlockedLanguagesPrefChange_.bind(this));
       Preferences.getInstance().addEventListener(SPELL_CHECK_DICTIONARIES_PREF,
           this.handleSpellCheckDictionariesPrefChange_.bind(this));
       Preferences.getInstance().addEventListener(ENABLE_TRANSLATE,
           this.handleEnableTranslatePrefChange_.bind(this));
       this.translateSupportedLanguages_ =
           loadTimeData.getValue('translateSupportedLanguages');
+      Preferences.getInstance().addEventListener(ENABLE_IME_MENU_FLAG_PREF,
+          this.handleEnableImeMenuFlagPrefChange_.bind(this));

[stevenjb, 2016/01/04 17:58:10]

Flags can not be changed at runtime so this is unnecessary.

[Azure Wei, 2016/01/05 06:48:03]

It was replaced with loadTimeData.

 
       // Set up add button.
       var onclick = function(e) {
         // Add the language without showing the overlay if it's specified in
         // the URL hash (ex. lang_add=ja).  Used for automated testing.
         var match = document.location.hash.match(/\blang_add=([\w-]+)/);
         if (match) {
           var addLanguageCode = match[1];
           $('language-options-list').addLanguage(addLanguageCode);
           this.addBlockedLanguage_(addLanguageCode);
@@ skipping 48 matching lines @@
           chrome.send('uiLanguageRestart');
         };
       }
 
       $('language-confirm').onclick =
           PageManager.closeOverlay.bind(PageManager);
 
       // Public session users cannot change the locale.
       if (cr.isChromeOS && UIAccountTweaks.loggedInAsPublicAccount())
         $('language-options-ui-language-section').hidden = true;
+
+      // Listen to check on 'activate-ime-menu' checkbox
+      var checkboxImeMenu = $('activate-ime-menu');
+      checkboxImeMenu.addEventListener('click',
+          this.handleActivateImeMenuCheckboxClick_.bind(this));
     },
 
     /**
      * Initializes the input method list.
      */
     initializeInputMethodList_: function() {
       var inputMethodList = $('language-options-input-method-list');
       var inputMethodPrototype = $('language-options-input-method-template');
 
       // Add all input methods, but make all of them invisible here. We'll
@@ skipping 717 matching lines @@
      * @private
      */
     handleEnableTranslatePrefChange_: function(e) {
       var enabled = e.value.value;
       this.enableTranslate_ = enabled;
       this.updateOfferToTranslateCheckbox_(
           $('language-options-list').getSelectedLanguageCode());
     },
 
     /**
+     * Handles enable-ime-menu change.
+     * @param {Event} e Change event.
+     * @private
+     */
+    handleEnableImeMenuFlagPrefChange_: function(e) {
+      $('language-options-ime-menu-template').hidden = !e.value.value;
+    },
+
+

[michaelpg, 2016/01/04 16:37:36]

remove extra newline

[Azure Wei, 2016/01/05 06:48:03]

Done.

+    /**
      * Handles spellCheckLanguageButton click.
      * @param {Event} e Click event.
      * @private
      */
     handleSpellCheckLanguageButtonClick_: function(e) {
       var languageCode = e.currentTarget.languageCode;
       // Save the preference.
       Preferences.setListPref(SPELL_CHECK_DICTIONARIES_PREF,
                               [languageCode], true);
 
@@ skipping 389 matching lines @@
       if (main in synonyms) {
         return synonyms[main];
       } else if (main == 'zh') {
         // In Translation, general Chinese is not used, and the sub code is
         // necessary as a language code for Translate server.
         return languageCode;
       }
 
       return main;
     },
+
+    /**
+     * Handles activate-ime-menu checkbox's click event.
+     * @param {Event} e Click event.
+     * @private
+     */
+    handleActivateImeMenuCheckboxClick_: function(e) {
+      var checkbox = e.target;
+      Preferences.setBooleanPref(ACTIVATE_IME_MENU_PREF,
+                                checkbox.checked, true);

[michaelpg, 2016/01/04 16:37:36]

indent off by 1

[Azure Wei, 2016/01/05 06:48:03]

Done.

+    },
   };
 
   /**
    * Shows the node at |index| in |nodes|, hides all others.
    * @param {Array<HTMLElement>} nodes The nodes to be shown or hidden.
    * @param {number} index The index of |nodes| to show.
    */
   function showMutuallyExclusiveNodes(nodes, index) {
     assert(index >= 0 && index < nodes.length);
     for (var i = 0; i < nodes.length; ++i) {
@@ skipping 16 matching lines @@
 
   LanguageOptions.onDictionaryDownloadFailure = function(languageCode) {
     LanguageOptions.getInstance().onDictionaryDownloadFailure_(languageCode);
   };
 
   // Export
   return {
     LanguageOptions: LanguageOptions
   };
 });