Add an option in language settings for activating the IME menu.

Add an option in language settings for activating the IME menu on the shelf.

A flag "enable-ime-menu" is added to turn on this feature. When building Chrome OS with the command line flag: --enable-ime-menu, the div section 'language-options-ime-menu-template' in language settings page will show. Otherwise, this section will be hidden.

Once the checkbox 'activate-ime-menu' is checked by users, the preference value pref::kLanguageImeMenuActivated will be set to be true.

BUG=570761
TEST=Verified bug not repro on local build.

Committed: https://crrev.com/103ed21273e49ddff067a378d0eed30a816bd1b4
Cr-Commit-Position: refs/heads/master@{#368529}

[Azure Wei, 2015-12-13 09:36:13]

Description was changed from

==========
Add an option in language settings for activating the IME menu on shelf

BUG=
TEST=Verified bug not repro on local build.
==========

to

==========
Add an option in language settings for activating the IME menu on shelf

BUG=
TEST=Verified bug not repro on local build.
==========

[Azure Wei, 2015-12-13 09:36:13]

azurewei@chromium.org changed reviewers:
+ shuchen@chromium.org

[Azure Wei, 2015-12-23 06:12:54]

Description was changed from

==========
Add an option in language settings for activating the IME menu on shelf

BUG=
TEST=Verified bug not repro on local build.
==========

to

==========
Add an option in language settings for activating the IME menu on shelf.
Add two events API: chrome.inputMethodPrivate.onImeMenuActivated and
chrome.inputMethodPrivate.onImeMenuDeactivated.
When user checked/unchecked the checkbox in language settings about IME Menu,
the event onImeMenuActivated/onImeMenuDeactivated will be fired to notice the
extension who is listening.

BUG=
TEST=Verified bug not repro on local build.
==========

[Azure Wei, 2015-12-23 06:13:33]

Description was changed from

==========
Add an option in language settings for activating the IME menu on shelf.
Add two events API: chrome.inputMethodPrivate.onImeMenuActivated and
chrome.inputMethodPrivate.onImeMenuDeactivated.
When user checked/unchecked the checkbox in language settings about IME Menu,
the event onImeMenuActivated/onImeMenuDeactivated will be fired to notice the
extension who is listening.

BUG=
TEST=Verified bug not repro on local build.
==========

to

==========
Add an option in language settings for activating the IME menu on shelf.
Add two events API: chrome.inputMethodPrivate.onImeMenuActivated and
chrome.inputMethodPrivate.onImeMenuDeactivated.
When user checked/unchecked the checkbox in language settings about IME Menu,
the event onImeMenuActivated/onImeMenuDeactivated will be fired to notice the
extension who is listening.

BUG=570761
TEST=Verified bug not repro on local build.
==========

[Azure Wei, 2015-12-23 08:10:59]

azurewei@chromium.org changed reviewers:
+ isherman@chromium.org, stevenjb@chromium.org

[Azure Wei, 2015-12-23 08:12:56]

Hi Shu Chen, stevenjb and Ilya Sherman, can you please help review this cl?
Thanks!

[Ilya Sherman, 2015-12-23 09:31:40]

histograms.xml lgtm

[stevenjb, 2015-12-28 16:33:28]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2015-12-28 16:33:28]

stevenjb@chromium.org changed required reviewers:
+ michaelpg@chromium.org

[stevenjb, 2015-12-28 16:33:28]

+michaelpg@ for chrome/browser/resources/options/

[Shu Chen, 2015-12-28 16:41:47]

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/ime_menu_event_router.cc (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/ime_menu_event_router.cc:27:
input_method::InputMethodManager* manager) {
Unused |manager| param.

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/ime_menu_event_router.cc:46:
input_method::InputMethodManager* manager) {
ditto.

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/input_method/input_method_manager_impl.cc:894:
ime_menu_observers_.AddObserver(observer);
pls put this behind a flag.

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/preferences.cc:289:
registry->RegisterBooleanPref(prefs::kLangugaeActivateImeMenu, false);
pls put this behind a flag.

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:283: var checkboxImeMenu =
$('activate-system-ime-menu');
pls put this behind a flag.

[stevenjb, 2015-12-28 17:36:11]

Renamed this because it has nothing directly to do with the Ash Shelf (that is
an implementation detail of Panels, which is how we intend to implement the
menu).

a) We should separate out the new preference and Settings UI change from the
extension API change.
b) We should use a single event, onImeMenuActivationChanged(bool activation).

https://codereview.chromium.org/1523593002/diff/60001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:3555: Activate the IME Menu on the system tray.
s/on the/in the/

https://codereview.chromium.org/1523593002/diff/60001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/common/pref_name...
chrome/common/pref_names.cc:507: // A boolean pref set to true if the system IME
menu is activated.
This really isn't a "system" menu since the current design has it created and
controlled by the extension.

[stevenjb, 2015-12-28 17:36:28]

stevenjb@chromium.org changed required reviewers:
- michaelpg@chromium.org

[Azure Wei, 2016-01-04 06:30:13]

On 2015/12/28 17:36:11, stevenjb wrote:
> Renamed this because it has nothing directly to do with the Ash Shelf (that is
> an implementation detail of Panels, which is how we intend to implement the
> menu).
> 
> a) We should separate out the new preference and Settings UI change from the
> extension API change.
> b) We should use a single event, onImeMenuActivationChanged(bool activation).
> 
>
https://codereview.chromium.org/1523593002/diff/60001/chrome/app/chromeos_str...
> File chrome/app/chromeos_strings.grdp (right):
> 
>
https://codereview.chromium.org/1523593002/diff/60001/chrome/app/chromeos_str...
> chrome/app/chromeos_strings.grdp:3555: Activate the IME Menu on the system
tray.
> s/on the/in the/
> 
>
https://codereview.chromium.org/1523593002/diff/60001/chrome/common/pref_name...
> File chrome/common/pref_names.cc (right):
> 
>
https://codereview.chromium.org/1523593002/diff/60001/chrome/common/pref_name...
> chrome/common/pref_names.cc:507: // A boolean pref set to true if the system
IME
> menu is activated.
> This really isn't a "system" menu since the current design has it created and
> controlled by the extension.

All those extension API related changes were removed from this cl. This cl now
only focuses on the language settings UI change. The new added checkbox will
show when command line flag 'enable-ime-menu' is used. And the variables with
'system' were renamed. 

Please review the newest patch set. Thank you!

[Azure Wei, 2016-01-04 06:30:38]

https://codereview.chromium.org/1523593002/diff/60001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:3555: Activate the IME Menu on the system tray.
On 2015/12/28 17:36:11, stevenjb wrote:
> s/on the/in the/

Updated this with the newest mocks: https://goo.gl/BYu2bd

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/extensions/ime_menu_event_router.cc (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/extensions/ime_menu_event_router.cc:27:
input_method::InputMethodManager* manager) {
On 2015/12/28 16:41:46, Shu Chen (OOO till Jan 6) wrote:
> Unused |manager| param.

This file will be added in another cl.

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/preferences.cc:289:
registry->RegisterBooleanPref(prefs::kLangugaeActivateImeMenu, false);
On 2015/12/28 16:41:47, Shu Chen (OOO till Jan 6) wrote:
> pls put this behind a flag.

Added a new flag 'enable-ime-menu'.

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/resource...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:283: var checkboxImeMenu =
$('activate-system-ime-menu');
On 2015/12/28 16:41:47, Shu Chen (OOO till Jan 6) wrote:
> pls put this behind a flag.

Done.

https://codereview.chromium.org/1523593002/diff/60001/chrome/common/pref_name...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/1523593002/diff/60001/chrome/common/pref_name...
chrome/common/pref_names.cc:507: // A boolean pref set to true if the system IME
menu is activated.
On 2015/12/28 17:36:11, stevenjb wrote:
> This really isn't a "system" menu since the current design has it created and
> controlled by the extension.

All these 'system' related comments were removed.

[michaelpg, 2016-01-04 16:37:37]

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/preferences.cc:289:
registry->RegisterBooleanPref(prefs::kLangugaeImeMenuFlagEnabled,
why is the flag also preference? do any other flags do this?

the pref isn't actually set anywhere, further suggesting we don't need it.

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:75: var
ENABLE_IME_MENU_FLAG_PREF = 'settings.language.ime_menu_flag_enabled';
i think we usually set flag info via loadTimeData using a boolean in
GetLocalizedValues

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:1040: 
remove extra newline

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:1460: checkbox.checked,
true);
indent off by 1

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
(right):

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc:88:
"activateImeMenu", l10n_util::GetStringUTF16(
nit: use consistent formatting with the above lines:

localized_strings->SetString("activateImeMenu",
    l10n_util::GetStringUTF16(
        IDS_WHATEVER));

[stevenjb, 2016-01-04 17:58:10]

https://codereview.chromium.org/1523593002/diff/80001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/1523593002/diff/80001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:3555: Show the input method menu on shelf.
s/on shelf/on the shelf/

https://codereview.chromium.org/1523593002/diff/80001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:3559: for easier switch of input methods, and
access to more input features: voice input, handwriting and emoji.
s/for/For/
s/switch/switching/
s/, and/and/

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:75: var
ENABLE_IME_MENU_FLAG_PREF = 'settings.language.ime_menu_flag_enabled';
On 2016/01/04 16:37:36, michaelpg wrote:
> i think we usually set flag info via loadTimeData using a boolean in
> GetLocalizedValues

Correct, e.g. see enableTimeZoneTrackingOption

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:221:
this.handleEnableImeMenuFlagPrefChange_.bind(this));
Flags can not be changed at runtime so this is unnecessary.

[Azure Wei, 2016-01-05 06:48:04]

https://codereview.chromium.org/1523593002/diff/80001/chrome/app/chromeos_str...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/1523593002/diff/80001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:3555: Show the input method menu on shelf.
On 2016/01/04 17:58:10, stevenjb wrote:
> s/on shelf/on the shelf/

Done.

https://codereview.chromium.org/1523593002/diff/80001/chrome/app/chromeos_str...
chrome/app/chromeos_strings.grdp:3559: for easier switch of input methods, and
access to more input features: voice input, handwriting and emoji.
On 2016/01/04 17:58:10, stevenjb wrote:
> s/for/For/
> s/switch/switching/
> s/, and/and/

Done.

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/chromeos...
File chrome/browser/chromeos/preferences.cc (right):

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/chromeos...
chrome/browser/chromeos/preferences.cc:289:
registry->RegisterBooleanPref(prefs::kLangugaeImeMenuFlagEnabled,
On 2016/01/04 16:37:36, michaelpg wrote:
> why is the flag also preference? do any other flags do this?
> 
> the pref isn't actually set anywhere, further suggesting we don't need it.

This preference was used in language_options.js, it has been changed with
loadTimeData now.

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:75: var
ENABLE_IME_MENU_FLAG_PREF = 'settings.language.ime_menu_flag_enabled';
On 2016/01/04 16:37:36, michaelpg wrote:
> i think we usually set flag info via loadTimeData using a boolean in
> GetLocalizedValues

Done.

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:75: var
ENABLE_IME_MENU_FLAG_PREF = 'settings.language.ime_menu_flag_enabled';
On 2016/01/04 17:58:10, stevenjb wrote:
> On 2016/01/04 16:37:36, michaelpg wrote:
> > i think we usually set flag info via loadTimeData using a boolean in
> > GetLocalizedValues
> 
> Correct, e.g. see enableTimeZoneTrackingOption

Done.

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:221:
this.handleEnableImeMenuFlagPrefChange_.bind(this));
On 2016/01/04 17:58:10, stevenjb wrote:
> Flags can not be changed at runtime so this is unnecessary.

It was replaced with loadTimeData.

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:1040: 
On 2016/01/04 16:37:36, michaelpg wrote:
> remove extra newline

Done.

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/language_options.js:1460: checkbox.checked,
true);
On 2016/01/04 16:37:36, michaelpg wrote:
> indent off by 1

Done.

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc
(right):

https://codereview.chromium.org/1523593002/diff/80001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/chromeos/cros_language_options_handler.cc:88:
"activateImeMenu", l10n_util::GetStringUTF16(
On 2016/01/04 16:37:36, michaelpg wrote:
> nit: use consistent formatting with the above lines:
> 
> localized_strings->SetString("activateImeMenu",
>     l10n_util::GetStringUTF16(
>         IDS_WHATEVER));

Done.

[stevenjb, 2016-01-05 17:31:13]

lgtm

https://codereview.chromium.org/1523593002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/1523593002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/options/language_options.js:1444: checkbox.checked,
true);
The preferred format is to align the arguments, i.e.
       Preferences.setBooleanPref(ACTIVATE_IME_MENU_PREF,
                                  checkbox.checked, true);

(Originally 'checkbox' was aligned with '(' instead of 'A')

[Shu Chen, 2016-01-06 04:42:32]

lgtm

[Azure Wei, 2016-01-07 03:04:58]

https://codereview.chromium.org/1523593002/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/1523593002/diff/100001/chrome/browser/resourc...
chrome/browser/resources/options/language_options.js:1444: checkbox.checked,
true);
On 2016/01/05 17:31:13, stevenjb wrote:
> The preferred format is to align the arguments, i.e.
>        Preferences.setBooleanPref(ACTIVATE_IME_MENU_PREF,
>                                   checkbox.checked, true);
> 
> (Originally 'checkbox' was aligned with '(' instead of 'A')

Done.

[michaelpg, 2016-01-08 02:43:40]

thanks for removing the flag pref! just a couple style nits.

https://codereview.chromium.org/1523593002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/1523593002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/options/language_options.js:281: if
(loadTimeData.getBoolean('enableLanguageOptionsImeMenu')) {
opt nit: leave off curly braces for one-line if statements (as above)

https://codereview.chromium.org/1523593002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/options/language_options.js:285: // Listen to check on
'activate-ime-menu' checkbox
nit: end comment with period

[Azure Wei, 2016-01-08 03:02:38]

https://codereview.chromium.org/1523593002/diff/140001/chrome/browser/resourc...
File chrome/browser/resources/options/language_options.js (right):

https://codereview.chromium.org/1523593002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/options/language_options.js:281: if
(loadTimeData.getBoolean('enableLanguageOptionsImeMenu')) {
On 2016/01/08 02:43:40, michaelpg wrote:
> opt nit: leave off curly braces for one-line if statements (as above)

Done.

https://codereview.chromium.org/1523593002/diff/140001/chrome/browser/resourc...
chrome/browser/resources/options/language_options.js:285: // Listen to check on
'activate-ime-menu' checkbox
On 2016/01/08 02:43:40, michaelpg wrote:
> nit: end comment with period

Done.

[michaelpg, 2016-01-08 03:09:49]

lgtm

[Azure Wei, 2016-01-08 03:10:42]

The CQ bit was checked by azurewei@chromium.org

[Azure Wei, 2016-01-08 03:10:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, shuchen@chromium.org, stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1523593002/#ps160001
(title: "Address michaelpg's commments")

[Azure Wei, 2016-01-08 03:10:44]

The CQ bit was unchecked by azurewei@chromium.org

[Azure Wei, 2016-01-08 03:10:51]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 03:11:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523593002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523593002/160001

[commit-bot: I haz the power, 2016-01-08 03:47:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 03:47:45]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Azure Wei, 2016-01-08 07:39:58]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-08 07:40:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523593002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523593002/180001

[commit-bot: I haz the power, 2016-01-08 08:49:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-08 08:49:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Azure Wei, 2016-01-10 06:12:18]

The CQ bit was checked by azurewei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-10 06:12:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523593002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523593002/200001

[Azure Wei, 2016-01-10 06:24:20]

Description was changed from

==========
Add an option in language settings for activating the IME menu on shelf.
Add two events API: chrome.inputMethodPrivate.onImeMenuActivated and
chrome.inputMethodPrivate.onImeMenuDeactivated.
When user checked/unchecked the checkbox in language settings about IME Menu,
the event onImeMenuActivated/onImeMenuDeactivated will be fired to notice the
extension who is listening.

BUG=570761
TEST=Verified bug not repro on local build.
==========

to

==========
Add an option in language settings for activating the IME menu on shelf.

A flag "enable-ime-menu" is added to turn on this feature. When building Chrome
OS with the command line flag: --enable-ime-flag, the div section
'language-options-ime-menu-template' in language settings page will show.
Otherwise, this section will be hidden. 
Once the checkbox 'activate-ime-menu' is checked by users, the preference value
pref::kLanguageImeMenuActivated will be set to be true. 

BUG=570761
TEST=Verified bug not repro on local build.
==========

[Azure Wei, 2016-01-10 06:27:45]

Description was changed from

==========
Add an option in language settings for activating the IME menu on shelf.

A flag "enable-ime-menu" is added to turn on this feature. When building Chrome
OS with the command line flag: --enable-ime-flag, the div section
'language-options-ime-menu-template' in language settings page will show.
Otherwise, this section will be hidden. 
Once the checkbox 'activate-ime-menu' is checked by users, the preference value
pref::kLanguageImeMenuActivated will be set to be true. 

BUG=570761
TEST=Verified bug not repro on local build.
==========

to

==========
Add an option in language settings for activating the IME menu on shelf.

A flag "enable-ime-menu" is added to turn on this feature. When building Chrome
OS with the command line flag: --enable-ime-menu, the div section
'language-options-ime-menu-template' in language settings page will show.
Otherwise, this section will be hidden. 

Once the checkbox 'activate-ime-menu' is checked by users, the preference value
pref::kLanguageImeMenuActivated will be set to be true. 

BUG=570761
TEST=Verified bug not repro on local build.
==========

[Azure Wei, 2016-01-10 06:29:08]

Description was changed from

==========
Add an option in language settings for activating the IME menu on shelf.

A flag "enable-ime-menu" is added to turn on this feature. When building Chrome
OS with the command line flag: --enable-ime-menu, the div section
'language-options-ime-menu-template' in language settings page will show.
Otherwise, this section will be hidden. 

Once the checkbox 'activate-ime-menu' is checked by users, the preference value
pref::kLanguageImeMenuActivated will be set to be true. 

BUG=570761
TEST=Verified bug not repro on local build.
==========

to

==========
Add an option in language settings for activating the IME menu on the shelf.

A flag "enable-ime-menu" is added to turn on this feature. When building Chrome
OS with the command line flag: --enable-ime-menu, the div section
'language-options-ime-menu-template' in language settings page will show.
Otherwise, this section will be hidden. 

Once the checkbox 'activate-ime-menu' is checked by users, the preference value
pref::kLanguageImeMenuActivated will be set to be true. 

BUG=570761
TEST=Verified bug not repro on local build.
==========

[commit-bot: I haz the power, 2016-01-10 06:55:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-10 06:55:03]

Dry run: This issue passed the CQ dry run.

[Azure Wei, 2016-01-10 06:56:46]

The CQ bit was checked by azurewei@chromium.org

[Azure Wei, 2016-01-10 06:56:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
shuchen@chromium.org, isherman@chromium.org, stevenjb@chromium.org,
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1523593002/#ps200001
(title: "Fix test failure.")

[commit-bot: I haz the power, 2016-01-10 06:56:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523593002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523593002/200001

[commit-bot: I haz the power, 2016-01-10 07:01:25]

Description was changed from

==========
Add an option in language settings for activating the IME menu on the shelf.

A flag "enable-ime-menu" is added to turn on this feature. When building Chrome
OS with the command line flag: --enable-ime-menu, the div section
'language-options-ime-menu-template' in language settings page will show.
Otherwise, this section will be hidden. 

Once the checkbox 'activate-ime-menu' is checked by users, the preference value
pref::kLanguageImeMenuActivated will be set to be true. 

BUG=570761
TEST=Verified bug not repro on local build.
==========

to

==========
Add an option in language settings for activating the IME menu on the shelf.

A flag "enable-ime-menu" is added to turn on this feature. When building Chrome
OS with the command line flag: --enable-ime-menu, the div section
'language-options-ime-menu-template' in language settings page will show.
Otherwise, this section will be hidden. 

Once the checkbox 'activate-ime-menu' is checked by users, the preference value
pref::kLanguageImeMenuActivated will be set to be true. 

BUG=570761
TEST=Verified bug not repro on local build.
==========

[commit-bot: I haz the power, 2016-01-10 07:01:26]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2016-01-10 07:02:27]

Description was changed from

==========
Add an option in language settings for activating the IME menu on the shelf.

A flag "enable-ime-menu" is added to turn on this feature. When building Chrome
OS with the command line flag: --enable-ime-menu, the div section
'language-options-ime-menu-template' in language settings page will show.
Otherwise, this section will be hidden. 

Once the checkbox 'activate-ime-menu' is checked by users, the preference value
pref::kLanguageImeMenuActivated will be set to be true. 

BUG=570761
TEST=Verified bug not repro on local build.
==========

to

==========
Add an option in language settings for activating the IME menu on the shelf.

A flag "enable-ime-menu" is added to turn on this feature. When building Chrome
OS with the command line flag: --enable-ime-menu, the div section
'language-options-ime-menu-template' in language settings page will show.
Otherwise, this section will be hidden.

Once the checkbox 'activate-ime-menu' is checked by users, the preference value
pref::kLanguageImeMenuActivated will be set to be true.

BUG=570761
TEST=Verified bug not repro on local build.

Committed: https://crrev.com/103ed21273e49ddff067a378d0eed30a816bd1b4
Cr-Commit-Position: refs/heads/master@{#368529}
==========

[commit-bot: I haz the power, 2016-01-10 07:02:29]

Patchset 11 (id:??) landed as
https://crrev.com/103ed21273e49ddff067a378d0eed30a816bd1b4
Cr-Commit-Position: refs/heads/master@{#368529}