Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1523563002: Fix dead code hints in summary code. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M pkg/analyzer/lib/src/summary/builder.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Paul Berry
5 years ago (2015-12-12 16:38:46 UTC) #3
Brian Wilkerson
LGTM. Thanks! I wasn't sure whether those should be cleaned up or left for near-future ...
5 years ago (2015-12-12 19:07:29 UTC) #4
scheglov
LGTM
5 years ago (2015-12-12 20:34:27 UTC) #5
Paul Berry
On 2015/12/12 19:07:29, Brian Wilkerson wrote: > LGTM. Thanks! I wasn't sure whether those should ...
5 years ago (2015-12-13 15:48:30 UTC) #6
Paul Berry
5 years ago (2015-12-13 15:54:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5117400c2bb7dec9a00f99f689fd252100814a70 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698