net/url_request/url_request_context.cc - Issue 1523433002: Remove support for a URLRequest having a NULL Delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_context.cc

Issue 1523433002: Remove support for a URLRequest having a NULL Delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge, remove if in file_writer_delegate Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/url_request/url_request_context.cc

diff --git a/net/url_request/url_request_context.cc b/net/url_request/url_request_context.cc

index b83cf023be39cc57c7d9aaa47cc81cf6aafc32dc..e9ab617dd583d881932a7b80f17efc0a80ba9d6e 100644

--- a/net/url_request/url_request_context.cc

+++ b/net/url_request/url_request_context.cc

@@ -94,14 +94,12 @@ void URLRequestContext::AssertNoURLRequests() const {

char url_buf[128];

const URLRequest* request = *url_requests_->begin();

base::strlcpy(url_buf, request->url().spec().c_str(), arraysize(url_buf));

- bool has_delegate = request->has_delegate();

int load_flags = request->load_flags();

base::debug::StackTrace stack_trace(NULL, 0);

if (request->stack_trace())

stack_trace = *request->stack_trace();

base::debug::Alias(url_buf);

base::debug::Alias(&num_requests);

- base::debug::Alias(&has_delegate);

base::debug::Alias(&load_flags);

base::debug::Alias(&stack_trace);

CHECK(false) << "Leaked " << num_requests << " URLRequest(s). First URL: "

« no previous file with comments | « net/url_request/url_request.cc ('k') | net/url_request/url_request_job.cc » ('j') | no next file with comments »