Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: content/browser/appcache/appcache_storage_impl_unittest.cc

Issue 1523433002: Remove support for a URLRequest having a NULL Delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge, remove if in file_writer_delegate Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/web/net/request_tracker_impl_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_storage_impl_unittest.cc
diff --git a/content/browser/appcache/appcache_storage_impl_unittest.cc b/content/browser/appcache/appcache_storage_impl_unittest.cc
index d6730537a833f1f26fa5bfcd74fb6617d21a2684..c7266954efab7ee54ed72993a07843514cf81efd 100644
--- a/content/browser/appcache/appcache_storage_impl_unittest.cc
+++ b/content/browser/appcache/appcache_storage_impl_unittest.cc
@@ -391,8 +391,7 @@ class AppCacheStorageImplTest : public testing::Test {
// Test harness --------------------------------------------------
- AppCacheStorageImplTest() {
- }
+ AppCacheStorageImplTest() { request_delegate_.set_quit_on_complete(false); }
template <class Method>
void RunTestOnIOThread(Method method) {
@@ -1765,7 +1764,7 @@ class AppCacheStorageImplTest : public testing::Test {
AppCacheHost* host2 = backend_->GetHost(2);
GURL manifest_url = MockHttpServer::GetMockUrl("manifest");
request_ = service()->request_context()->CreateRequest(
- manifest_url, net::DEFAULT_PRIORITY, NULL);
+ manifest_url, net::DEFAULT_PRIORITY, &request_delegate_);
AppCacheInterceptor::SetExtraRequestInfo(
request_.get(), service_.get(),
backend_->process_id(), host2->host_id(),
@@ -1891,6 +1890,7 @@ class AppCacheStorageImplTest : public testing::Test {
scoped_ptr<MockServiceObserver> observer_;
MockAppCacheFrontend frontend_;
scoped_ptr<AppCacheBackendImpl> backend_;
+ net::TestDelegate request_delegate_;
scoped_ptr<net::URLRequest> request_;
};
« no previous file with comments | « no previous file | ios/web/net/request_tracker_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698