Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: ios/web/net/request_tracker_impl_unittest.mm

Issue 1523433002: Remove support for a URLRequest having a NULL Delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix iOS Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/net/request_tracker_impl_unittest.mm
diff --git a/ios/web/net/request_tracker_impl_unittest.mm b/ios/web/net/request_tracker_impl_unittest.mm
index 0c8e76ec9fcf6ab87fb3ff86439be7c3f7504c4c..5765b3abb33ff3f520c5c2c1b5b09e49447746e5 100644
--- a/ios/web/net/request_tracker_impl_unittest.mm
+++ b/ios/web/net/request_tracker_impl_unittest.mm
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "base/mac/scoped_nsobject.h"
+#include "base/macros.h"
#include "base/memory/scoped_vector.h"
#include "base/message_loop/message_loop.h"
#include "base/strings/sys_string_conversions.h"
@@ -121,6 +122,19 @@ namespace {
// Used and incremented each time a tabId is created.
int g_count = 0;
+// URLRequest::Delegate that does nothing.
+class DummyURLRequestDelegate : public net::URLRequest::Delegate {
+ public:
+ DummyURLRequestDelegate() {}
+ ~DummyURLRequestDelegate() override {}
+
+ void OnResponseStarted(net::URLRequest* request) override {}
+ void OnReadCompleted(net::URLRequest* request, int bytes_read) override {}
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(DummyURLRequestDelegate);
+};
+
class RequestTrackerTest : public PlatformTest {
public:
RequestTrackerTest()
@@ -239,9 +253,10 @@ class RequestTrackerTest : public PlatformTest {
while (i >= requests_.size()) {
contexts_.push_back(new net::URLRequestContext());
- requests_.push_back(contexts_[i]->CreateRequest(url,
- net::DEFAULT_PRIORITY,
- NULL).release());
+ requests_.push_back(
+ contexts_[i]
+ ->CreateRequest(url, net::DEFAULT_PRIORITY, &request_delegate_)
+ .release());
if (secure) {
// Put a valid SSLInfo inside
@@ -262,6 +277,8 @@ class RequestTrackerTest : public PlatformTest {
return requests_[i];
}
+ DummyURLRequestDelegate request_delegate_;
+
DISALLOW_COPY_AND_ASSIGN(RequestTrackerTest);
};

Powered by Google App Engine
This is Rietveld 408576698