Remove support for a URLRequest having a NULL Delegate.

content/browser/appcache/appcache_storage_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stack>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/files/file_util.h"
@@ skipping 373 matching lines @@
     ASSERT_TRUE(db_thread->StartWithOptions(options));
   }
 
   static void TearDownTestCase() {
     io_thread.reset(NULL);
     db_thread.reset(NULL);
   }
 
   // Test harness --------------------------------------------------
 
-  AppCacheStorageImplTest() {
-  }
+  AppCacheStorageImplTest() { request_delegate_.set_quit_on_complete(false); }

[mmenke, 2015/12/14 17:02:30]

Note that I used a different approach here and request_tracker_impl_unittest.mm,
largely because I consider AppCache more integrated into the network stack, so
more reasonable to depend on funky net classes, like TestDelegate.  They could
just both use the same solution.

 
   template <class Method>
   void RunTestOnIOThread(Method method) {
     test_finished_event_ .reset(new base::WaitableEvent(false, false));
     io_thread->task_runner()->PostTask(
         FROM_HERE, base::Bind(&AppCacheStorageImplTest::MethodWrapper<Method>,
                               base::Unretained(this), method));
     test_finished_event_->Wait();
   }
 
@@ skipping 1352 matching lines @@
                          MockHttpServer::GetMockUrl("manifest"));
     } else {
       ASSERT_EQ(CORRUPT_CACHE_ON_LOAD_EXISTING, test_case);
       // Try to access the existing cache manifest.
       // The URLRequestJob  will eventually fail when it gets to disk
       // cache initialization.
       backend_->RegisterHost(2);
       AppCacheHost* host2 = backend_->GetHost(2);
       GURL manifest_url = MockHttpServer::GetMockUrl("manifest");
       request_ = service()->request_context()->CreateRequest(
-          manifest_url, net::DEFAULT_PRIORITY, NULL);
+          manifest_url, net::DEFAULT_PRIORITY, &request_delegate_);
       AppCacheInterceptor::SetExtraRequestInfo(
           request_.get(), service_.get(),
           backend_->process_id(), host2->host_id(),
           RESOURCE_TYPE_MAIN_FRAME,
           false);
       request_->Start();
     }
 
     PushNextTask(base::Bind(
         &AppCacheStorageImplTest::Verify_Reinitialized,
@@ skipping 105 matching lines @@
   scoped_refptr<MockQuotaManagerProxy> mock_quota_manager_proxy_;
   scoped_refptr<AppCacheGroup> group_;
   scoped_refptr<AppCache> cache_;
   scoped_refptr<AppCache> cache2_;
 
   // Specifically for the Reinitalize test.
   base::ScopedTempDir temp_directory_;
   scoped_ptr<MockServiceObserver> observer_;
   MockAppCacheFrontend frontend_;
   scoped_ptr<AppCacheBackendImpl> backend_;
+  net::TestDelegate request_delegate_;
   scoped_ptr<net::URLRequest> request_;
 };
 
 
 TEST_F(AppCacheStorageImplTest, LoadCache_Miss) {
   RunTestOnIOThread(&AppCacheStorageImplTest::LoadCache_Miss);
 }
 
 TEST_F(AppCacheStorageImplTest, LoadCache_NearHit) {
   RunTestOnIOThread(&AppCacheStorageImplTest::LoadCache_NearHit);
@@ skipping 117 matching lines @@
   RunTestOnIOThread(&AppCacheStorageImplTest::Reinitialize2);
 }
 
 TEST_F(AppCacheStorageImplTest, Reinitialize3) {
   RunTestOnIOThread(&AppCacheStorageImplTest::Reinitialize3);
 }
 
 // That's all folks!
 
 }  // namespace content