Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 152343006: Clean-up: Replaces obsolete Font/FontList methods. (Closed)

Created:
6 years, 10 months ago by Yuki
Modified:
6 years, 10 months ago
Reviewers:
msw
CC:
chromium-reviews, asanka, dtseng+watch_chromium.org, plundblad+watch_chromium.org, benjhayden+dwatch_chromium.org, benquan, tfarina, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, aboxhall+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, James Su, Ilya Sherman, rouslan+autofillwatch_chromium.org, dmazzoni+watch_chromium.org
Visibility:
Public.

Description

Clean-up: Replaces obsolete Font/FontList methods. Replaces obsolete methods of gfx::Font and gfx::FontList with new ones. BUG=265485 TEST=Run unit_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248902

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed Mike's review comments. #

Patch Set 3 : Synced. #

Patch Set 4 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -53 lines) Patch
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_loading_shield_controller.mm View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser/password_generation_bubble_controller.mm View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_gtk.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/validation_message_bubble_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/accessibility/invert_bubble_view.cc View 1 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/download/download_danger_prompt_views.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/first_run_bubble.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 1 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
Yuki
Could you review this CL? Thanks.
6 years, 10 months ago (2014-02-03 13:08:21 UTC) #1
msw
https://codereview.chromium.org/152343006/diff/1/chrome/browser/ui/views/accessibility/invert_bubble_view.cc File chrome/browser/ui/views/accessibility/invert_bubble_view.cc (right): https://codereview.chromium.org/152343006/diff/1/chrome/browser/ui/views/accessibility/invert_bubble_view.cc#newcode28 chrome/browser/ui/views/accessibility/invert_bubble_view.cc:28: "https://chrome.google.com/webstore/detail/" The style guide allows string literals to exceed ...
6 years, 10 months ago (2014-02-04 00:58:20 UTC) #2
Yuki
https://codereview.chromium.org/152343006/diff/1/chrome/browser/ui/views/accessibility/invert_bubble_view.cc File chrome/browser/ui/views/accessibility/invert_bubble_view.cc (right): https://codereview.chromium.org/152343006/diff/1/chrome/browser/ui/views/accessibility/invert_bubble_view.cc#newcode28 chrome/browser/ui/views/accessibility/invert_bubble_view.cc:28: "https://chrome.google.com/webstore/detail/" On 2014/02/04 00:58:20, msw wrote: > The style ...
6 years, 10 months ago (2014-02-04 03:03:06 UTC) #3
msw
LGTM
6 years, 10 months ago (2014-02-04 03:21:05 UTC) #4
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 03:27:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152343006/70001
6 years, 10 months ago (2014-02-04 03:29:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 04:49:41 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120432
6 years, 10 months ago (2014-02-04 04:49:41 UTC) #8
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 04:57:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152343006/70001
6 years, 10 months ago (2014-02-04 04:58:36 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 06:10:57 UTC) #11
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120490
6 years, 10 months ago (2014-02-04 06:10:57 UTC) #12
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 06:15:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152343006/560001
6 years, 10 months ago (2014-02-04 06:16:41 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 07:01:09 UTC) #15
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=222870
6 years, 10 months ago (2014-02-04 07:01:10 UTC) #16
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-04 07:27:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152343006/560001
6 years, 10 months ago (2014-02-04 07:28:56 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 08:35:12 UTC) #19
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120583
6 years, 10 months ago (2014-02-04 08:35:12 UTC) #20
Yuki
The CQ bit was checked by yukishiino@chromium.org
6 years, 10 months ago (2014-02-05 04:57:40 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/152343006/1030001
6 years, 10 months ago (2014-02-05 05:06:09 UTC) #22
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 07:36:09 UTC) #23
Message was sent while issue was closed. 
Change committed as 248902

Powered by Google App Engine
This is Rietveld 408576698