Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1523423002: Flipping FEC flag at client to enable FEC protection on connection from client to server. (Closed)

Created:
5 years ago by Jana
Modified:
5 years ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@home
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flipping FEC flag at client to enable FEC protection on connection from client to server. R=rch@chromium.org BUG= Committed: https://crrev.com/abc35c951aef78e67913b44932cd55e976cc39a9 Cr-Commit-Position: refs/heads/master@{#365574}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/quic/quic_flags.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Jana
5 years ago (2015-12-15 23:15:48 UTC) #1
Ryan Hamilton
lgtm Wow, I'm surprised no tests broke. Woo hoo! :>
5 years ago (2015-12-15 23:40:43 UTC) #2
Jana
On 2015/12/15 23:40:43, Ryan Hamilton wrote: > lgtm > > Wow, I'm surprised no tests ...
5 years ago (2015-12-16 17:25:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523423002/1
5 years ago (2015-12-16 17:26:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 18:40:10 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abc35c951aef78e67913b44932cd55e976cc39a9 Cr-Commit-Position: refs/heads/master@{#365574}
5 years ago (2015-12-16 18:40:50 UTC) #8
Ryan Hamilton
4 years, 11 months ago (2016-01-04 18:54:10 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1560443002/ by rch@chromium.org.

The reason for reverting is: Might expose bug in FEC timeouts..

Powered by Google App Engine
This is Rietveld 408576698