Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1523393003: [turbofan] move down parallel moves (Closed)

Created:
5 years ago by Mircea Trofin
Modified:
5 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] move down parallel moves. The regression the bug tracks (see the bug link) appears to be due to identical gap moves in the predecessors of a block not being moved to the common successor. This CR fixes one reason that is happening. BUG=chromium:549262 LOG=n Committed: https://crrev.com/888c0c2d8bc521b63cb629065c804e070f858171 Cr-Commit-Position: refs/heads/master@{#32874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M src/compiler/move-optimizer.cc View 1 chunk +14 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Mircea Trofin
5 years ago (2015-12-16 00:04:50 UTC) #6
Benedikt Meurer
lgtm
5 years ago (2015-12-16 04:52:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523393003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523393003/1
5 years ago (2015-12-16 04:52:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 04:56:22 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-16 04:56:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/888c0c2d8bc521b63cb629065c804e070f858171
Cr-Commit-Position: refs/heads/master@{#32874}

Powered by Google App Engine
This is Rietveld 408576698