Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1523373003: PPC: [turbofan] Make MachineType a pair of enums. (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Make MachineType a pair of enums. Port bb2a830debbff19cf5a510c920ff9ac88d41355c Port 56673804e026b297a5165e6f807f55aaaad6c6ee Original commit messages: MachineType is now a class with two enum fields: - MachineRepresentation - MachineSemantic Both enums are usable on their own, and this change switches some places from using MachineType to use just MachineRepresentation. Most notably: - register allocator now uses just the representation. - Phi and Select nodes only refer to representations. Store nodes use only MachineRepresentation, not MachineType. R=jarin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/4903f82c6aa8368baa0ca3beaf3f1b7436f031de Cr-Commit-Position: refs/heads/master@{#32916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -45 lines) Patch
M src/compiler/ppc/instruction-selector-ppc.cc View 7 chunks +42 lines, -45 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
5 years ago (2015-12-16 19:27:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523373003/1
5 years ago (2015-12-16 19:28:04 UTC) #3
michael_dawson
On 2015/12/16 19:28:04, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
5 years ago (2015-12-16 19:29:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-16 20:00:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523373003/1
5 years ago (2015-12-16 20:01:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 20:02:53 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-16 20:03:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4903f82c6aa8368baa0ca3beaf3f1b7436f031de
Cr-Commit-Position: refs/heads/master@{#32916}

Powered by Google App Engine
This is Rietveld 408576698