Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1523353002: Fixes for html report (Closed)

Created:
5 years ago by vsm
Modified:
5 years ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes for html report This forces a regen of the summary when a file is recompiled. It also suppresses dart: entries during normal compilation. R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/9b93a41b64c9e1ae875b119af563c5faa826d0c8

Patch Set 1 #

Patch Set 2 : Reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -11 lines) Patch
M lib/src/report/html_reporter.dart View 1 1 chunk +4 lines, -2 lines 0 comments Download
M lib/src/server/dependency_graph.dart View 1 4 chunks +23 lines, -9 lines 0 comments Download
M lib/src/server/server.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
5 years ago (2015-12-15 19:34:11 UTC) #3
Jennifer Messerly
lgtm
5 years ago (2015-12-15 20:17:32 UTC) #4
vsm
5 years ago (2015-12-15 20:27:18 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9b93a41b64c9e1ae875b119af563c5faa826d0c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698