Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1523343002: impl/prod: Fix logging field output. (Closed)

Created:
5 years ago by dnj
Modified:
5 years ago
Reviewers:
Vadim Sh., iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

impl/prod: Fix logging field output. By using the AppEngine context, logging calls would not have access to logging fields that were set in subsequent contexts (most of them). Retain both the AppEngine context (for logging calls) and the logger context (for up-to-date logging configuration), and use the latter for field extraction. R=iannucci@chromium.org BUG= Committed: https://github.com/luci/gae/commit/0cee85427df47b0f078eb36116971d5eb8869d8f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M impl/prod/logger.go View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dnj
PTAL
5 years ago (2015-12-15 19:18:19 UTC) #1
Vadim Sh.
I noticed this regression too. LGTM.
5 years ago (2015-12-15 19:20:38 UTC) #3
iannucci
Ah, woops! lgtm
5 years ago (2015-12-15 19:21:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523343002/1
5 years ago (2015-12-15 19:40:15 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-15 19:41:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/0cee85427df47b0f078eb36116971d5eb8869d8f

Powered by Google App Engine
This is Rietveld 408576698