Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: chromeos/network/network_configuration_handler.cc

Issue 15233002: Add NetworkStateHandler::RequestUpdateForNetwork (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add request call for NetworkConfigurationHandler::CreateConfiguration Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_configuration_handler.cc
diff --git a/chromeos/network/network_configuration_handler.cc b/chromeos/network/network_configuration_handler.cc
index 22a8998b43837661b60129698523f019abbf32c6..91c87a0ddd6dab83d7e47a9c6a68c2e7f8114d3f 100644
--- a/chromeos/network/network_configuration_handler.cc
+++ b/chromeos/network/network_configuration_handler.cc
@@ -16,6 +16,7 @@
#include "chromeos/dbus/dbus_thread_manager.h"
#include "chromeos/dbus/shill_manager_client.h"
#include "chromeos/dbus/shill_service_client.h"
+#include "chromeos/network/network_state_handler.h"
#include "dbus/object_path.h"
#include "third_party/cros_system_api/dbus/service_constants.h"
@@ -96,6 +97,11 @@ void RunCreateNetworkCallback(
const network_handler::StringResultCallback& callback,
const dbus::ObjectPath& service_path) {
callback.Run(service_path.value());
+ // This may also get called when CreateConfiguration is used to update an
+ // existing configuration, so request a service update just in case.
+ // TODO(pneubeck): Separate 'Create' and 'Update' calls and only trigger
+ // this on an update.
+ NetworkStateHandler::Get()->RequestUpdateForNetwork(service_path.value());
}
void IgnoreObjectPathCallback(const base::Closure& callback,
@@ -147,6 +153,7 @@ void NetworkConfigurationHandler::SetProperties(
base::Bind(&IgnoreObjectPathCallback, callback),
base::Bind(&network_handler::ShillErrorCallbackFunction,
service_path, error_callback));
+ NetworkStateHandler::Get()->RequestUpdateForNetwork(service_path);
}
void NetworkConfigurationHandler::ClearProperties(
« no previous file with comments | « chromeos/network/network_configuration_handler.h ('k') | chromeos/network/network_configuration_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698