Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1523273002: Measure SVGSVGElement.viewport (Closed)

Created:
5 years ago by davve
Modified:
5 years ago
CC:
chromium-reviews, krit, kouhei+svg_chromium.org, fs, f(malita), asvitkine+watch_chromium.org, blink-reviews, gyuyoung2, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Measure SVGSVGElement.viewport The implementation is trivial but entirely useless and has been since 2012. The attribute is not present at all in Gecko. It has been removed from the spec: http://www.w3.org/Graphics/SVG/WG/track/actions/3815 BUG=395838, 415074 Committed: https://crrev.com/9791cf9d8b005fc7cb8b589b099fcc33ba02ce2b Cr-Commit-Position: refs/heads/master@{#365515}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGSVGElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
davve
+philipj for third_party/WebKit, +isherman for histograms.xml.
5 years ago (2015-12-15 14:14:27 UTC) #2
philipj_slow
lgtm
5 years ago (2015-12-15 14:15:37 UTC) #3
fs
I think you could reference crbug.com/395838 too.
5 years ago (2015-12-15 14:22:18 UTC) #5
davve
On 2015/12/15 14:22:18, fs wrote: > I think you could reference crbug.com/395838 too. Done.
5 years ago (2015-12-15 14:24:34 UTC) #8
Ilya Sherman
histograms.xml lgtm
5 years ago (2015-12-15 23:17:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523273002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523273002/20001
5 years ago (2015-12-16 07:51:59 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-16 11:20:04 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-16 11:21:13 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9791cf9d8b005fc7cb8b589b099fcc33ba02ce2b
Cr-Commit-Position: refs/heads/master@{#365515}

Powered by Google App Engine
This is Rietveld 408576698