Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1523243006: move OpType into dart folder (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2195 lines) Patch
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/optype.dart View 1 chunk +0 lines, -696 lines 0 comments Download
A + pkg/analysis_server/test/services/completion/dart/optype_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
D pkg/analysis_server/test/services/completion/optype_test.dart View 1 chunk +0 lines, -1484 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-18 17:27:03 UTC) #2
scheglov
LGTM
5 years ago (2015-12-18 19:53:33 UTC) #3
danrubel
5 years ago (2015-12-19 16:11:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
43ee7b5bc9849d1fb9963a9d707a16f5a49f11b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698