Apply inherited or initial value when custom property reference fails to resolve / parse.

Apply inherited / initial value when custom property reference fails to
resolve / parse.

This fixes a couple of the imported Firefox bugs that test falling back
on the inherited value when a custom property reference becomes invalid
at computation time. We were previously falling back to property values
from other rules instead.

BUG=465126
Committed: https://crrev.com/2f99aca8d8b529627da91711101e21c842435c0f
Cr-Commit-Position: refs/heads/master@{#365494}

[shans, 2015-12-16 04:16:15]

shans@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2015-12-16 04:34:52]

Description could probably explain why we need to do this. It'd be nicer to just
use createUnsetValue() here and leaving the inherited check to
StyleBuilder::applyProperty. Also if you need local CSSValues, you need to use
RefPtrWillBeRawPtr.

BTW I think it'd be nice if we (separately) changed
resolveAndApplyVariableReferences to something like:
// Returns nullptr iff the property is a shorthand, in which case we apply the
values immediately 
PassRefPtrWillBeRawPtr<CSSValue> resolveVariableReferences(..)

so in the normal (non-shorthand) case, we avoid the recursive call applyProperty
-> resolveAndApply -> applyProperty.

[shans, 2015-12-16 04:44:03]

Description was changed from

==========
Apply inherited or initial value when custom property reference fails to resolve
/ parse.

BUG=465126
==========

to

==========
Apply inherited or initial value when custom property reference fails to resolve
/ parse.

This fixes a couple of the imported Firefox bugs that test falling back on the
inherited value when a custom property reference becomes invalid at computation
time. We were previously falling back to property values from other rules
instead.

BUG=465126
==========

[shans, 2015-12-16 04:44:10]

On 2015/12/16 at 04:34:52, timloh wrote:
> Description could probably explain why we need to do this. It'd be nicer to
just use createUnsetValue() here and leaving the inherited check to
StyleBuilder::applyProperty. Also if you need local CSSValues, you need to use
RefPtrWillBeRawPtr.
> 
> BTW I think it'd be nice if we (separately) changed
resolveAndApplyVariableReferences to something like:
> // Returns nullptr iff the property is a shorthand, in which case we apply the
values immediately 
> PassRefPtrWillBeRawPtr<CSSValue> resolveVariableReferences(..)
> 
> so in the normal (non-shorthand) case, we avoid the recursive call
applyProperty -> resolveAndApply -> applyProperty.

Done, ptal

[shans, 2015-12-16 04:46:17]

Description was changed from

==========
Apply inherited or initial value when custom property reference fails to resolve
/ parse.

This fixes a couple of the imported Firefox bugs that test falling back on the
inherited value when a custom property reference becomes invalid at computation
time. We were previously falling back to property values from other rules
instead.

BUG=465126
==========

to

==========
Apply inherited / initial value when custom property reference fails to
resolve / parse.

This fixes a couple of the imported Firefox bugs that test falling back
on the inherited value when a custom property reference becomes invalid
at computation time. We were previously falling back to property values
from other rules instead.

BUG=465126
==========

[Timothy Loh, 2015-12-16 04:46:28]

On 2015/12/16 04:44:10, shans wrote:
> On 2015/12/16 at 04:34:52, timloh wrote:
> > Description could probably explain why we need to do this. It'd be nicer to
> just use createUnsetValue() here and leaving the inherited check to
> StyleBuilder::applyProperty. Also if you need local CSSValues, you need to use
> RefPtrWillBeRawPtr.
> > 
> > BTW I think it'd be nice if we (separately) changed
> resolveAndApplyVariableReferences to something like:
> > // Returns nullptr iff the property is a shorthand, in which case we apply
the
> values immediately 
> > PassRefPtrWillBeRawPtr<CSSValue> resolveVariableReferences(..)
> > 
> > so in the normal (non-shorthand) case, we avoid the recursive call
> applyProperty -> resolveAndApply -> applyProperty.
> 
> Done, ptal

lgtm

[shans, 2015-12-16 05:05:11]

The CQ bit was checked by shans@chromium.org

[commit-bot: I haz the power, 2015-12-16 05:07:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523243003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523243003/20001

[commit-bot: I haz the power, 2015-12-16 07:10:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-16 07:11:48]

Description was changed from

==========
Apply inherited / initial value when custom property reference fails to
resolve / parse.

This fixes a couple of the imported Firefox bugs that test falling back
on the inherited value when a custom property reference becomes invalid
at computation time. We were previously falling back to property values
from other rules instead.

BUG=465126
==========

to

==========
Apply inherited / initial value when custom property reference fails to
resolve / parse.

This fixes a couple of the imported Firefox bugs that test falling back
on the inherited value when a custom property reference becomes invalid
at computation time. We were previously falling back to property values
from other rules instead.

BUG=465126

Committed: https://crrev.com/2f99aca8d8b529627da91711101e21c842435c0f
Cr-Commit-Position: refs/heads/master@{#365494}
==========

[commit-bot: I haz the power, 2015-12-16 07:11:49]

Patchset 2 (id:??) landed as
https://crrev.com/2f99aca8d8b529627da91711101e21c842435c0f
Cr-Commit-Position: refs/heads/master@{#365494}