Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1523243002:
[qcms] Apply qcms color matching api to Blink images (Closed)
|
Created:
5 years ago by Noel Gordon Modified:
5 years ago Reviewers:
Justin Novosad CC:
chromium-reviews, blink-reviews, jzern, skal, urvang, vikasa, enne (OOO), scroggo_chromium, reed1 Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[qcms] Apply qcms color matching api to Blink images
During image decoding, detect if the image color profile matches
the device profile. If they match, there is no need to create or
apply a color transform to the image.
Prior to this change, we would apply the transform and that adds
needless perf overhead and color distortion (a precision loss).
New test: fast/images/color-profile-munsell-srgb-to-srgb.html to
transform a Munsell test chart image from sRGB to sRGB (note the
default profile of the testRunner page is sRGB) then compare the
output colors to the expected Munsell colors [1].
color-profile-munsell-srgb-to-srgb.html is designed to be run in
the test harness automatically, but also manually to help detect
color changes should that happen in future. The physical colors,
and tabulated color results, of this test are correct and should
never change or be rebaselined. If the colors changed, that is a
colorimetric error: the offending CL should be reverted.
Change in behavior now transforms are skipped: collect the tests
that change in TestExpectations, all are progressions, mark them
[ NeedsRebaseline ].
[1] For more details on Munsell colors and gamuts, see
http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html
BUG=569919
Committed: https://crrev.com/433ddcbf9f0c48cd3e25a9d0f252709d440dde26
Cr-Commit-Position: refs/heads/master@{#365506}
Patch Set 1 : Gather layout test changes #Patch Set 2 : Update TestExpectations, add sRGB to sRGB layout test #
Total comments: 13
Patch Set 3 : Update TestExpectations: account for crbug.com/569600 #
Messages
Total messages: 51 (31 generated)
Description was changed from ========== Get test expectations changes for qcms color matching api BUG=None ========== to ========== Get test expectations changes for qcms color matching api BUG=569919 ==========
Description was changed from ========== Get test expectations changes for qcms color matching api BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to images BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. When they match, there's no need to create a color transform for the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the the output colors to expected Munsell colors. Change in behavoir now transforms are skipped: collect the tests that changed in TestExpectations, all are progressions, and mark them [ NeedsRebaseline ]. BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. When they match, there's no need to create a color transform for the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the the output colors to expected Munsell colors. Change in behavoir now transforms are skipped: collect the tests that changed in TestExpectations, all are progressions, and mark them [ NeedsRebaseline ]. BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the the output colors to expected Munsell colors. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. BUG=569919 ==========
noel@chromium.org changed reviewers: + junov@chromium.org
PTAL
Description was changed from ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the the output colors to expected Munsell colors. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. BUG=569919 ==========
https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html (right): https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html:9: a:link { text-decoration: none } the style block has non-trivial style which, at first glance, does not appear to be relevant to what is being tested. https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html:12: <body style="overflow: hidden"> why this style? https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html:15: <pre id="log" style="font-size: 9pt"></pre> Why this style? https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html:16: <a href="http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html"> I don't think it is a good idea to write tests that reference content from the web at large. https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/images/resources/color-checker-munsell-chart.js (right): https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/images/resources/color-checker-munsell-chart.js:133: log('\nResult: total RMS color error: ' + Math.sqrt(totalSquaredError / 24.0).toFixed(2)); Printing this value makes the test extremely sensitive, meaning that it will need to be rebaselined everytime there is the slightest change. Also I would argue that this test does not need pixel results. Maybe this level of sensitivity is what we want, but have you considered just printing PASS or FAIL based on a tolerance threshold. Also, what is the rationale for using RMS? Simple alternative: In the loop above, you could just use an equality test (with a tolerance parameter). https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp (right): https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:658: qcms_profile_release(inputProfile); There is no test to verify that this code path is actually used. It would make sense to have a unit test that verifies that m_transform does not get set under conditions where this optimization is expected to kick in. Same thing for the other decoders.
Description was changed from ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error and the offending change should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error and the offending change should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending change should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending change should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending change should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For details about Munsell colors, and color gamuts, refer to http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending change should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For details about Munsell colors, and color gamuts, refer to http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending change should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For details about Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html (right): https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html:9: a:link { text-decoration: none } On 2015/12/15 21:10:59, Justin Novosad wrote: > the style block has non-trivial style which, at first glance, does not appear to > be relevant to what is being tested. Mostly relevant to manual testing; this test is designed to be both an automatic test and a manual test. If something goes wrong with our color handling causing the colors in this test to change, then loading this test manually is an aid to debugging why the colors changed. The colors in this test should never change. I added a paragraph about all this to the change description. https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html:12: <body style="overflow: hidden"> On 2015/12/15 21:10:58, Justin Novosad wrote: > why this style? To constrain the results to 800 x 600 due to some bots 9pt text being bigger than other bots 9pt text. 9pt text should ideally be the same size everywhere, but is not. Without this style, scroll bars result on some bots. I added this style to prevent scroll-bars appearing in this test, when it is run manually or automatically. https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html:15: <pre id="log" style="font-size: 9pt"></pre> On 2015/12/15 21:10:58, Justin Novosad wrote: > Why this style? Mentioned above. https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/images/color-profile-munsell-srgb-to-srgb.html:16: <a href="http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html"> On 2015/12/15 21:10:59, Justin Novosad wrote: > I don't think it is a good idea to write tests that reference content from the > web at large. Tend to agree, it's not something I would ordinarily do. In this case though, the Cyan color situation is hard to describe succinctly. The GIF animation on the referenced page does that way better than words could. It shows the Munsell colors relative to the sRGB gamut, that gamuts are 3D objects, and that Munsell Cyan is the only Munsell color that it outside the sRGB gamut. Second, it lists the Munsell color values in sRGB color space (and other color spaces), and they can be compared to the Munsell RGB values I added to color array in the test JS code, which is useful for cross-checking ... like did I enter the right values in the color array and did you check them? Without that canonical reference source, it'd be pretty difficult to do imho. So it was thirdly provided (helpfully) so that you could easily verify if I had entered the Munsell data correctly or not :) I believe it to be a very handy reference for this test, so I made an exception and added the link. One might be running this test manually, and the link works in that case, and so gets the referenced information to our finger tips pronto. https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/images/resources/color-checker-munsell-chart.js (right): https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/images/resources/color-checker-munsell-chart.js:133: log('\nResult: total RMS color error: ' + Math.sqrt(totalSquaredError / 24.0).toFixed(2)); On 2015/12/15 21:10:59, Justin Novosad wrote: > Printing this value makes the test extremely sensitive, meaning that it will > need to be rebaselined everytime there is the slightest change. The results of this test should never be changed. Added notes to the change description about that. The correct answer for all the dE values in the columns, and the RMS error, is precisely 0. Why? Because a color transform is not being applied, since the source and destination profiles are the same, right? That means the source and destination pixels should be identical. The dE and RMS values should be exactly 0, and that's the sensitivity we want. If the colors did change in future, there has been a colorimetric error - the offending patch should be reverted. > Also I would > argue that this test does not need pixel results. The test can be run manually. Having the pixel results and the OSX Color Meter in my hand aids debugging. If the colors changed in future, we'd wanna know why. Having the pixel results and Color Meter Tool helps answer the question, "So where did they change?" > Maybe this level of sensitivity is what we want, I think so, given the above. The result should never change, should not be changed. A lot of thought went into designing this test, looking back. > but have you considered just printing PASS or FAIL > based on a tolerance threshold. > Also, what is the rationale for using RMS? > Simple alternative: In the loop above, you could just use an equality test (with > a tolerance parameter). RMS is used since Lindbloom uses it, and we also use it for our qcms test, and other tests. You might recall [1], see the linked tables therein, they also use dE. It is an accepted (though only a first order) measure of color difference. It allows for quick cross comparison. [1] http://bit.ly/1Gkadze https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp (right): https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:658: qcms_profile_release(inputProfile); On 2015/12/15 21:10:59, Justin Novosad wrote: > There is no test to verify that this code path is actually used. It would make > sense to have a unit test that verifies that m_transform does not get set under > conditions where this optimization is expected to kick in. Same thing for the > other decoders. Actually the number of tests that changed behavior tell me otherwise. Applying color transforms where none is needed, introduces color distortion. We no longer do that, and plenty of tests said so. As I said in the change description, "all were progressions", and some person had to stare at all the pixel results of 99 tests to confirm that. That was me. We could always improve coverage, but 99 tests seems pretty good to me at this time.
Description was changed from ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending change should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For details about Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending change should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details about Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
Thanks for all the explanations. lgtm https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp (right): https://codereview.chromium.org/1523243002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp:658: qcms_profile_release(inputProfile); On 2015/12/16 05:00:32, noel gordon wrote: > On 2015/12/15 21:10:59, Justin Novosad wrote: > > There is no test to verify that this code path is actually used. It would make > > sense to have a unit test that verifies that m_transform does not get set > under > > conditions where this optimization is expected to kick in. Same thing for the > > other decoders. > > Actually the number of tests that changed behavior tell me otherwise. Applying > color transforms where none is needed, introduces color distortion. We no > longer do that, and plenty of tests said so. As I said in the change > description, "all were progressions", and some person had to stare at all the > pixel results of 99 tests to confirm that. That was me. We could always improve > coverage, but 99 tests seems pretty good to me at this time. Okay, so that proves the patch is working. And I suppose we can rely on tests in qcms to guard against regressions in qcms_profile_match
On 2015/12/16 05:25:26, Justin Novosad wrote: > Thanks for all the explanations. > > lgtm Yeah, color is a deep technical subject. Don't mean to bore you with, I hope you found the answers useful. > > We could always improve > > coverage, but 99 tests seems pretty good to me at this time. > Okay, so that proves the patch is working. And I suppose we can rely on tests in > qcms to guard against regressions in qcms_profile_match Yeah, we could always use more tests, even unit tests as you recommenced. I think that is a good idea. The toBlob and toDataURL tests were helpful here, btw, but we could add more these there too.
The CQ bit was checked by noel@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523243002/20001
going CQ+ for now. > I think so, given the above. The result should never change, should not be changed. In a followup, I should add a comment "you may not rebaseline this test" to the .html test code.
On 2015/12/16 05:43:57, noel gordon wrote: > going CQ+ for now. ** Presubmit ERRORS ** LayoutTests/TestExpectations:1061 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:90 and LayoutTests/TestExpectations:1061. css3/filters/effect-blur-hw.html LayoutTests/TestExpectations:1062 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:100 and LayoutTests/TestExpectations:1062. css3/filters/effect-drop-shadow-hw.html LayoutTests/TestExpectations:1063 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:110 and LayoutTests/TestExpectations:1063. css3/filters/effect-reference-colorspace-hw.html LayoutTests/TestExpectations:1064 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:115 and LayoutTests/TestExpectations:1064. css3/filters/effect-reference-hidpi-hw.html LayoutTests/TestExpectations:1065 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:117 and LayoutTests/TestExpectations:1065. css3/filters/effect-reference-hw.html LayoutTests/TestExpectations:1066 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:118 and LayoutTests/TestExpectations:1066. css3/filters/effect-reference-ordering-hw.html LayoutTests/TestExpectations:1067 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:123 and LayoutTests/TestExpectations:1067. css3/filters/effect-reference-subregion-hw.html LayoutTests/TestExpectations:1068 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:125 and LayoutTests/TestExpectations:1068. css3/filters/effect-reference-zoom-hw.html man-o-man!!!
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
CQ-, syncing up yada freaking yada
The CQ bit was checked by noel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org Link to the patchset: https://codereview.chromium.org/1523243002/#ps40001 (title: "Subtract the https://crbug.com/569600 manuals from my TestExpectation set")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523243002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523243002/40001
The CQ bit was unchecked by noel@chromium.org
Patchset #3 (id:40001) has been deleted
The CQ bit was checked by noel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org Link to the patchset: https://codereview.chromium.org/1523243002/#ps60001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523243002/60001
On 2015/12/16 05:43:57, noel gordon wrote: > In a followup, I should add a comment "you may not rebaseline this test" to the > .html test code. Added, upload had no TestExpectations nits, going CQ+ again.
Description was changed from ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending change should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details about Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details about Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details about Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image (that adds unnecessary perf overhead and can cause color distortions). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image (that adds unnecessary perf overhead and can cause color distortions). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. Prior to this change, we would apply the transform and that adds unwanted perf overhead and color distortions (precision loss). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. Prior to this change, we would apply the transform and that adds unwanted perf overhead and color distortions (precision loss). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. Prior to this change, we would apply the transform and that adds needless perf overhead and color distortions (precision loss). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
Description was changed from ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. Prior to this change, we would apply the transform and that adds needless perf overhead and color distortions (precision loss). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. Prior to this change, we would apply the transform and that adds needless perf overhead and color distortion (a precision loss). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
Patchset #4 (id:80001) has been deleted
Uploaded TestExpectations: svg/custom/repaint-shadow.svg flakes on [ Mac10.9 ]
On 2015/12/16 07:28:26, noel gordon wrote: > Uploaded TestExpectations: svg/custom/repaint-shadow.svg flakes on [ Mac10.9 ] https://codereview.chromium.org/1532483002 landed.
On 2015/12/16 07:32:08, noel gordon wrote: > On 2015/12/16 07:28:26, noel gordon wrote: > > Uploaded TestExpectations: svg/custom/repaint-shadow.svg flakes on [ Mac10.9 ] > https://codereview.chromium.org/1532483002 landed. Flake was http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_... and was the second time I've seen it today.
The CQ bit was checked by noel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org Link to the patchset: https://codereview.chromium.org/1523243002/#ps60001 (title: "Update TestExpectations: account for crbug.com/569600")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523243002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523243002/60001
Message was sent while issue was closed.
Description was changed from ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. Prior to this change, we would apply the transform and that adds needless perf overhead and color distortion (a precision loss). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. Prior to this change, we would apply the transform and that adds needless perf overhead and color distortion (a precision loss). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. Prior to this change, we would apply the transform and that adds needless perf overhead and color distortion (a precision loss). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 ========== to ========== [qcms] Apply qcms color matching api to Blink images During image decoding, detect if the image color profile matches the device profile. If they match, there is no need to create or apply a color transform to the image. Prior to this change, we would apply the transform and that adds needless perf overhead and color distortion (a precision loss). New test: fast/images/color-profile-munsell-srgb-to-srgb.html to transform a Munsell test chart image from sRGB to sRGB (note the default profile of the testRunner page is sRGB) then compare the output colors to the expected Munsell colors [1]. color-profile-munsell-srgb-to-srgb.html is designed to be run in the test harness automatically, but also manually to help detect color changes should that happen in future. The physical colors, and tabulated color results, of this test are correct and should never change or be rebaselined. If the colors changed, that is a colorimetric error: the offending CL should be reverted. Change in behavior now transforms are skipped: collect the tests that change in TestExpectations, all are progressions, mark them [ NeedsRebaseline ]. [1] For more details on Munsell colors and gamuts, see http://www.brucelindbloom.com/index.html?ColorCheckerRGB.html BUG=569919 Committed: https://crrev.com/433ddcbf9f0c48cd3e25a9d0f252709d440dde26 Cr-Commit-Position: refs/heads/master@{#365506} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/433ddcbf9f0c48cd3e25a9d0f252709d440dde26 Cr-Commit-Position: refs/heads/master@{#365506} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
