Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1523163006: Make WebContentsImpl::UpdateState navigation enties DCHECK conditional (Closed)

Created:
5 years ago by nasko
Modified:
5 years ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WebContentsImpl::UpdateState navigation enties DCHECK conditional When swapped out state is not used, a RenderViewHost is not guaranteed to have a valid RenderFrameHost for the main frame. It is useful to keep the DCHECK, but this CL makes it conditional on the presence of a main RenderFrameHost. BUG=357747 Committed: https://crrev.com/346969918900aa4b42f9836e1cdc29ff53c43b7c Cr-Commit-Position: refs/heads/master@{#365642}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
nasko
Hey Charlie, This is split out from the disable swapped out CL mainly to keep ...
5 years ago (2015-12-16 21:26:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523163006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523163006/1
5 years ago (2015-12-16 21:28:46 UTC) #4
Charlie Reis
LGTM
5 years ago (2015-12-16 22:15:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523163006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523163006/1
5 years ago (2015-12-16 22:21:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 22:36:54 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-16 22:38:01 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/346969918900aa4b42f9836e1cdc29ff53c43b7c
Cr-Commit-Position: refs/heads/master@{#365642}

Powered by Google App Engine
This is Rietveld 408576698