clang/win: Fix build after https://codereview.chromium.org/1496093002

clang/win: Fix build after https://codereview.chromium.org/1496093002

clang was complaining that it wasn't clear if the if (owner = foo) expression
was an assignment (in which case one usually writes if ((owner = foo))) or
a comparison where == was meant instead of =:

..\..\chrome\installer\mini_installer\mini_installer.cc(575,15) :
    error: using the result of an assignment as a condition without parentheses
        [-Werror,-Wparentheses]
    if (owner = reinterpret_cast<TOKEN_OWNER*>(::LocalAlloc(LPTR, size))) {
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Rather than just add parentheses, declare owner in this if, as it's not really
used outside the scope of the if.

BUG=82385
TBR=jschuh@chromium.org

[Nico, 2015-12-16 13:38:50]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2015-12-16 13:39:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1523163005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1523163005/1

[commit-bot: I haz the power, 2015-12-16 13:58:10]

Description was changed from

==========
clang/win: Fix build after https://codereview.chromium.org/1496093002

clang was complaining that it wasn't clear if the if (owner = foo) expression
was an assignment (in which case one usually writes if ((owner = foo))) or
a comparison where == was meant instead of =:

..\..\chrome\installer\mini_installer\mini_installer.cc(575,15) :
    error: using the result of an assignment as a condition without parentheses
        [-Werror,-Wparentheses]
    if (owner = reinterpret_cast<TOKEN_OWNER*>(::LocalAlloc(LPTR, size))) {
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Rather than just add parentheses, declare owner in this if, as it's not really
used outside the scope of the if.

BUG=82385
TBR=jschuh@chromium.org
==========

to

==========
clang/win: Fix build after https://codereview.chromium.org/1496093002

clang was complaining that it wasn't clear if the if (owner = foo) expression
was an assignment (in which case one usually writes if ((owner = foo))) or
a comparison where == was meant instead of =:

..\..\chrome\installer\mini_installer\mini_installer.cc(575,15) :
    error: using the result of an assignment as a condition without parentheses
        [-Werror,-Wparentheses]
    if (owner = reinterpret_cast<TOKEN_OWNER*>(::LocalAlloc(LPTR, size))) {
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Rather than just add parentheses, declare owner in this if, as it's not really
used outside the scope of the if.

BUG=82385
TBR=jschuh@chromium.org

Committed: https://crrev.com/415f7da181d489b006cd5ef6c4c8f7098ffeb65c
Cr-Commit-Position: refs/heads/master@{#365519}
==========

[commit-bot: I haz the power, 2015-12-16 13:58:11]

Patchset 1 (id:??) landed as
https://crrev.com/415f7da181d489b006cd5ef6c4c8f7098ffeb65c
Cr-Commit-Position: refs/heads/master@{#365519}

[Nico, 2015-12-16 13:58:56]

Description was changed from

==========
clang/win: Fix build after https://codereview.chromium.org/1496093002

clang was complaining that it wasn't clear if the if (owner = foo) expression
was an assignment (in which case one usually writes if ((owner = foo))) or
a comparison where == was meant instead of =:

..\..\chrome\installer\mini_installer\mini_installer.cc(575,15) :
    error: using the result of an assignment as a condition without parentheses
        [-Werror,-Wparentheses]
    if (owner = reinterpret_cast<TOKEN_OWNER*>(::LocalAlloc(LPTR, size))) {
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Rather than just add parentheses, declare owner in this if, as it's not really
used outside the scope of the if.

BUG=82385
TBR=jschuh@chromium.org

Committed: https://crrev.com/415f7da181d489b006cd5ef6c4c8f7098ffeb65c
Cr-Commit-Position: refs/heads/master@{#365519}
==========

to

==========
clang/win: Fix build after https://codereview.chromium.org/1496093002

clang was complaining that it wasn't clear if the if (owner = foo) expression
was an assignment (in which case one usually writes if ((owner = foo))) or
a comparison where == was meant instead of =:

..\..\chrome\installer\mini_installer\mini_installer.cc(575,15) :
    error: using the result of an assignment as a condition without parentheses
        [-Werror,-Wparentheses]
    if (owner = reinterpret_cast<TOKEN_OWNER*>(::LocalAlloc(LPTR, size))) {
        ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Rather than just add parentheses, declare owner in this if, as it's not really
used outside the scope of the if.

BUG=82385
TBR=jschuh@chromium.org
==========

[Nico, 2015-12-16 13:58:57]

Committed patchset #1 (id:1) to pending queue manually as
86a447914185488ac9f9512203cacf280c5b065b (presubmit successful).

[jschuh, 2015-12-16 18:39:27]

lgtm, and thanks for cleaning it up