Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1523113002: [Translate] Add unit tests for TranslateManager (Closed)

Created:
5 years ago by groby-ooo-7-16
Modified:
5 years ago
Reviewers:
hajimehoshi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Translate] Add unit tests for TranslateManager We will be looking at changing the target language algorithm. As a preparation for that, adding unit tests to establish a baseline. BUG=569219 R=hajimehoshi@chromium.org Committed: https://crrev.com/6e5b8cba7511ceba6d3876ec8820b862ac045df8 Cr-Commit-Position: refs/heads/master@{#365419}

Patch Set 1 #

Patch Set 2 : Disable downloading server-side language list for tests. #

Patch Set 3 : Reset TranslateDownloadManager before/after testing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1 line) Patch
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/translate/core/browser/translate_download_manager.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/translate/core/browser/translate_language_list_unittest.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A components/translate/core/browser/translate_manager_unittest.cc View 1 2 1 chunk +63 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
groby-ooo-7-16
5 years ago (2015-12-14 21:59:12 UTC) #1
hajimehoshi
lgtm
5 years ago (2015-12-15 06:04:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523113002/1
5 years ago (2015-12-15 06:05:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/107924)
5 years ago (2015-12-15 06:20:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523113002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523113002/40001
5 years ago (2015-12-16 00:48:59 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-16 02:44:28 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-16 02:45:52 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6e5b8cba7511ceba6d3876ec8820b862ac045df8
Cr-Commit-Position: refs/heads/master@{#365419}

Powered by Google App Engine
This is Rietveld 408576698