Move code unrelated to info collection from collector to data manager in Android.

Move code unrelated to info collection from collector to data manager in Android.

First, this is the right thing to do, to put code in the right place.
Second, this removed gpu_info_collector's dependency on content, so unblock us from moving them to gpu side.

BUG=241162
TEST=workarounds on Android still take place
R=gman@chromium.org, sievers@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200664

[Zhenyao Mo, 2013-05-16 20:43:11]

Daniel, Patrick: please review.

[no sievers, 2013-05-16 23:04:24]

lgtm. Thanks for cleaning that up! I assume this still gets called early enough
so that the cmdline gets passed along to the renderer (the tile sizes need to go
to the renderer).

You probably want to look at the failed blacklist-related unittest on
android_dbg_triggered_tests :)

https://codereview.chromium.org/15231003/diff/1/content/browser/gpu/gpu_data_...
File content/browser/gpu/gpu_data_manager_impl_private.cc (left):

https://codereview.chromium.org/15231003/diff/1/content/browser/gpu/gpu_data_...
content/browser/gpu/gpu_data_manager_impl_private.cc:42: #endif
Shouldn't the includes be here? http://www.chromium.org/developers/coding-style
still says to include platform-specific headers after the regular includes.

[Zhenyao Mo, 2013-05-16 23:06:59]

On 2013/05/16 23:04:24, Daniel Sievers wrote:
> lgtm. Thanks for cleaning that up! I assume this still gets called early
enough
> so that the cmdline gets passed along to the renderer (the tile sizes need to
go
> to the renderer).

Yes, the call is right after it's original place and there are no other code in
between these two locations, so we are safe here.

> 
> You probably want to look at the failed blacklist-related unittest on
> android_dbg_triggered_tests :)

This should be fixed by patch set 2.

> 
>
https://codereview.chromium.org/15231003/diff/1/content/browser/gpu/gpu_data_...
> File content/browser/gpu/gpu_data_manager_impl_private.cc (left):
> 
>
https://codereview.chromium.org/15231003/diff/1/content/browser/gpu/gpu_data_...
> content/browser/gpu/gpu_data_manager_impl_private.cc:42: #endif
> Shouldn't the includes be here?
http://www.chromium.org/developers/coding-style
> still says to include platform-specific headers after the regular includes.

[Zhenyao Mo, 2013-05-16 23:10:34]

https://codereview.chromium.org/15231003/diff/1/content/browser/gpu/gpu_data_...
File content/browser/gpu/gpu_data_manager_impl_private.cc (left):

https://codereview.chromium.org/15231003/diff/1/content/browser/gpu/gpu_data_...
content/browser/gpu/gpu_data_manager_impl_private.cc:42: #endif
On 2013/05/16 23:04:24, Daniel Sievers wrote:
> Shouldn't the includes be here?
http://www.chromium.org/developers/coding-style
> still says to include platform-specific headers after the regular includes.

Done.

[Zhenyao Mo, 2013-05-17 00:03:31]

Al is out. Gregg, can you review this as owner?

[greggman, 2013-05-17 00:12:07]

lgtm

[Zhenyao Mo, 2013-05-17 00:12:40]

Committed patchset #3 manually as r200664 (presubmit successful).