Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1523053003: add backdrop option to SaveLayerRec (Closed)

Created:
5 years ago by reed1
Modified:
4 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Patch Set 3 : rename to backdrop #

Patch Set 4 : #

Patch Set 5 : now with gm #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : manual rebase #

Patch Set 9 : updated gm to exercise ctm scaling #

Total comments: 4

Patch Set 10 : update SaveLayer in pictures to know about backdrop #

Patch Set 11 : update old picture so we can serialize backdrop #

Patch Set 12 : manual rebase now that get_paint_offset is gone #

Patch Set 13 : ignore the hack in sampleapp.cpp, just for testing #

Total comments: 2

Patch Set 14 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -29 lines) Patch
M gm/imagefilters.cpp View 1 2 3 4 5 6 7 8 1 chunk +74 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +15 lines, -4 lines 0 comments Download
M include/private/SkRecords.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +9 lines, -0 lines 0 comments Download
M samplecode/SampleLayers.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +74 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +10 lines, -8 lines 0 comments Download
M src/core/SkPictureFlat.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +10 lines, -2 lines 0 comments Download
M src/core/SkPicturePlayback.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +19 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +36 lines, -10 lines 0 comments Download
M src/core/SkRecordDraw.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRecorder.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 36 (15 generated)
reed1
5 years ago (2015-12-14 20:55:39 UTC) #2
robertphillips
I like it https://codereview.chromium.org/1523053003/diff/1/include/core/SkCanvas.h File include/core/SkCanvas.h (right): https://codereview.chromium.org/1523053003/diff/1/include/core/SkCanvas.h#newcode345 include/core/SkCanvas.h:345: dox ? https://codereview.chromium.org/1523053003/diff/1/samplecode/SampleLayers.cpp File samplecode/SampleLayers.cpp (right): ...
5 years ago (2015-12-15 13:28:38 UTC) #3
bsalomon
On 2015/12/15 at 13:28:38, robertphillips wrote: > I like it > > https://codereview.chromium.org/1523053003/diff/1/include/core/SkCanvas.h > File ...
5 years ago (2015-12-15 14:15:03 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523053003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523053003/80001
5 years ago (2015-12-18 16:32:12 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/4869) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on ...
5 years ago (2015-12-18 16:32:59 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523053003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523053003/140001
5 years ago (2015-12-18 17:49:26 UTC) #11
reed1
need to plumb-through the backdrop into pictures/pipe, but ready for review otherwise
5 years ago (2015-12-18 17:49:55 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-18 18:07:19 UTC) #14
bsalomon
On 2015/12/18 17:49:55, reed1 wrote: > need to plumb-through the backdrop into pictures/pipe, but ready ...
5 years ago (2015-12-18 18:10:50 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523053003/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523053003/160001
5 years ago (2015-12-18 23:12:49 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-19 00:11:11 UTC) #19
robertphillips
https://codereview.chromium.org/1523053003/diff/160001/samplecode/SampleLayers.cpp File samplecode/SampleLayers.cpp (right): https://codereview.chromium.org/1523053003/diff/160001/samplecode/SampleLayers.cpp#newcode238 samplecode/SampleLayers.cpp:238: Do we need Blur or MatrixConvolution ? https://codereview.chromium.org/1523053003/diff/160001/samplecode/SampleLayers.cpp#newcode245 samplecode/SampleLayers.cpp:245: ...
4 years, 11 months ago (2016-01-04 20:12:56 UTC) #20
reed1
https://codereview.chromium.org/1523053003/diff/160001/samplecode/SampleLayers.cpp File samplecode/SampleLayers.cpp (right): https://codereview.chromium.org/1523053003/diff/160001/samplecode/SampleLayers.cpp#newcode238 samplecode/SampleLayers.cpp:238: On 2016/01/04 20:12:56, robertphillips wrote: > Do we need ...
4 years, 11 months ago (2016-01-04 20:49:02 UTC) #22
reed1
please look at old picture changes, so we can serialize the backdrop
4 years, 11 months ago (2016-01-04 21:41:00 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523053003/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523053003/240001
4 years, 11 months ago (2016-01-04 22:23:20 UTC) #26
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 22:41:04 UTC) #28
robertphillips
lgtm % debug code https://codereview.chromium.org/1523053003/diff/240001/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.chromium.org/1523053003/diff/240001/samplecode/SampleApp.cpp#newcode1387 samplecode/SampleApp.cpp:1387: Delete this ?
4 years, 11 months ago (2016-01-05 22:24:34 UTC) #29
reed1
https://codereview.chromium.org/1523053003/diff/240001/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.chromium.org/1523053003/diff/240001/samplecode/SampleApp.cpp#newcode1387 samplecode/SampleApp.cpp:1387: On 2016/01/05 22:24:34, robertphillips wrote: > Delete this ? ...
4 years, 11 months ago (2016-01-07 15:27:11 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523053003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523053003/260001
4 years, 11 months ago (2016-01-07 15:27:26 UTC) #33
commit-bot: I haz the power
Committed patchset #14 (id:260001) as https://skia.googlesource.com/skia/+/247415969a9a5ed6c83cc09395472416c4b7de7f
4 years, 11 months ago (2016-01-07 15:44:38 UTC) #35
reed1
4 years, 11 months ago (2016-01-07 16:14:59 UTC) #36
Message was sent while issue was closed. 
A revert of this CL (patchset #14 id:260001) has been created in
https://codereview.chromium.org/1565203002/ by reed@google.com.

The reason for reverting is: serialized != direct, will investigate.

Powered by Google App Engine
This is Rietveld 408576698