Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1523023002: Documentation: text shaping (Closed)

Created:
5 years ago by hal.canary
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : 2015-12-14 (Monday) 12:24:31 EST #

Total comments: 1

Patch Set 2 : 2015-12-14 (Monday) 13:00:31 EST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M site/user/tips.md View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
hal.canary
PTAL
5 years ago (2015-12-14 17:26:04 UTC) #8
bungeman-skia
lgtm
5 years ago (2015-12-14 17:44:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523023002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523023002/60001
5 years ago (2015-12-14 17:49:42 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:60001) as https://skia.googlesource.com/skia/+/a58d67603b45713abfa6b881a888e095b5852194
5 years ago (2015-12-14 17:50:18 UTC) #13
caryclark
5 years ago (2015-12-14 17:51:23 UTC) #14
Message was sent while issue was closed. 
https://codereview.chromium.org/1523023002/diff/60001/site/user/tips.md
File site/user/tips.md (right):

https://codereview.chromium.org/1523023002/diff/60001/site/user/tips.md#newco...
site/user/tips.md:153: text shaper. Skia's client's often use Harfbuzz to
generate the glyphs
How about a link to harfbuzz.org (or
http://www.freedesktop.org/wiki/Software/HarfBuzz/ )?

Powered by Google App Engine
This is Rietveld 408576698