Fix for GrAALinearizingConvexPathRenderer incorrectly drawing non-convex paths

Fix for GrAALinearizingConvexPathRenderer incorrectly drawing non-convex paths

BUG=552080
Committed: https://skia.googlesource.com/skia/+/c88cb8942e9b0097784d048dc2734b9e0d4391d1

[ethannicholas, 2015-12-14 15:59:56]

ethannicholas@google.com changed reviewers:
+ joshualitt@chromium.org, reed@google.com

[ethannicholas, 2015-12-14 16:13:45]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-14 16:13:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1522973002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1522973002/1

[commit-bot: I haz the power, 2015-12-14 16:38:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-14 16:38:04]

Dry run: This issue passed the CQ dry run.

[joshualitt, 2015-12-14 18:29:11]

On 2015/12/14 16:38:04, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Mike you should really review this, I don't know enough about paths.

[reed1, 2015-12-14 18:52:09]

cam we add some unittests? tests are allowed to see private headers.

https://codereview.chromium.org/1522973002/diff/1/src/core/SkPathPriv.h
File src/core/SkPathPriv.h (right):

https://codereview.chromium.org/1522973002/diff/1/src/core/SkPathPriv.h#newco...
src/core/SkPathPriv.h:64: for (int i = 0; i < verbCount; i++) {
Is this loop traversing forwards or backwards through the verbs (hard to know
since we store them funnily)?

[ethannicholas, 2015-12-14 20:09:49]

Added some tests and a comment to make the iteration order more clear.

[reed1, 2015-12-15 15:33:18]

lgtm

https://codereview.chromium.org/1522973002/diff/20001/src/core/SkPathPriv.h
File src/core/SkPathPriv.h (right):

https://codereview.chromium.org/1522973002/diff/20001/src/core/SkPathPriv.h#n...
src/core/SkPathPriv.h:66: switch (verb) {
nit:

switch (verbs[~i]) {  // do we need verb as a variable?

[ethannicholas, 2015-12-15 18:46:16]

The CQ bit was checked by ethannicholas@google.com

[ethannicholas, 2015-12-15 18:46:16]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1522973002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-12-15 18:46:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1522973002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1522973002/40001

[commit-bot: I haz the power, 2015-12-15 19:01:14]

Description was changed from

==========
Fix for GrAALinearizingConvexPathRenderer incorrectly drawing non-convex paths

BUG=552080
==========

to

==========
Fix for GrAALinearizingConvexPathRenderer incorrectly drawing non-convex paths

BUG=552080

Committed:
https://skia.googlesource.com/skia/+/c88cb8942e9b0097784d048dc2734b9e0d4391d1
==========

[commit-bot: I haz the power, 2015-12-15 19:01:15]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/c88cb8942e9b0097784d048dc2734b9e0d4391d1