[Downloads] Use final URL for resumption.

[Downloads] Use final URL for resumption.

If the initial download request contains multiple redirects, then the
resumption attempt should only use the final URL. Strong validators are
only valid when used against the same URL.

R=svaldez@chromium.org
BUG=7468
Committed: https://crrev.com/6ac869dac34c217329d8a23c8cb4f5472e0758df
Cr-Commit-Position: refs/heads/master@{#365295}

[asanka, 2015-12-14 22:28:06]

Description was changed from

==========
[Downloads] Use final URL for resumption.

If the initial download request contains multiple redirects, then the
resumption attempt should only use the final URL. Strong validators are
only valid when used against the same URL.

BUG=7468
==========

to

==========
[Downloads] Use final URL for resumption.

If the initial download request contains multiple redirects, then the
resumption attempt should only use the final URL. Strong validators are
only valid when used against the same URL.

R=svaldez@chromium.org
BUG=7468
==========

[asanka, 2015-12-14 22:28:18]

Description was changed from

==========
[Downloads] Use final URL for resumption.

If the initial download request contains multiple redirects, then the
resumption attempt should only use the final URL. Strong validators are
only valid when used against the same URL.

R=svaldez@chromium.org
BUG=7468
==========

to

==========
[Downloads] Use final URL for resumption.

If the initial download request contains multiple redirects, then the
resumption attempt should only use the final URL. Strong validators are
only valid when used against the same URL.

R=svaldez@chromium.org
BUG=7468
==========

[asanka, 2015-12-14 22:28:19]

asanka@chromium.org changed reviewers:
+ svaldez@chromium.org

[asanka, 2015-12-14 22:28:36]

PTAL?

[svaldez, 2015-12-15 15:11:50]

lgtm

https://codereview.chromium.org/1522893004/diff/1/content/browser/download/do...
File content/browser/download/download_item_impl_unittest.cc (right):

https://codereview.chromium.org/1522893004/diff/1/content/browser/download/do...
content/browser/download/download_item_impl_unittest.cc:219: static uint32
next_id = DownloadItem::kInvalidId + 1;
nit: Possibly move this out of the CreateDownload and make it part of the
fixture? Otherwise its probably fine here.

[asanka, 2015-12-15 17:31:16]

The CQ bit was checked by asanka@chromium.org

[asanka, 2015-12-15 17:31:16]

The patchset sent to the CQ was uploaded after l-g-t-m from svaldez@chromium.org
Link to the patchset: https://codereview.chromium.org/1522893004/#ps10001
(title: "Make download id be a property of the fixture.")

[asanka, 2015-12-15 17:32:27]

https://codereview.chromium.org/1522893004/diff/1/content/browser/download/do...
File content/browser/download/download_item_impl_unittest.cc (right):

https://codereview.chromium.org/1522893004/diff/1/content/browser/download/do...
content/browser/download/download_item_impl_unittest.cc:219: static uint32
next_id = DownloadItem::kInvalidId + 1;
On 2015/12/15 15:11:50, svaldez wrote:
> nit: Possibly move this out of the CreateDownload and make it part of the
> fixture? Otherwise its probably fine here.

Done.

[commit-bot: I haz the power, 2015-12-15 17:33:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1522893004/10001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1522893004/10001

[commit-bot: I haz the power, 2015-12-15 18:47:17]

Description was changed from

==========
[Downloads] Use final URL for resumption.

If the initial download request contains multiple redirects, then the
resumption attempt should only use the final URL. Strong validators are
only valid when used against the same URL.

R=svaldez@chromium.org
BUG=7468
==========

to

==========
[Downloads] Use final URL for resumption.

If the initial download request contains multiple redirects, then the
resumption attempt should only use the final URL. Strong validators are
only valid when used against the same URL.

R=svaldez@chromium.org
BUG=7468
==========

[commit-bot: I haz the power, 2015-12-15 18:47:18]

Committed patchset #2 (id:10001)

[commit-bot: I haz the power, 2015-12-15 18:48:21]

Description was changed from

==========
[Downloads] Use final URL for resumption.

If the initial download request contains multiple redirects, then the
resumption attempt should only use the final URL. Strong validators are
only valid when used against the same URL.

R=svaldez@chromium.org
BUG=7468
==========

to

==========
[Downloads] Use final URL for resumption.

If the initial download request contains multiple redirects, then the
resumption attempt should only use the final URL. Strong validators are
only valid when used against the same URL.

R=svaldez@chromium.org
BUG=7468

Committed: https://crrev.com/6ac869dac34c217329d8a23c8cb4f5472e0758df
Cr-Commit-Position: refs/heads/master@{#365295}
==========

[commit-bot: I haz the power, 2015-12-15 18:48:22]

Patchset 2 (id:??) landed as
https://crrev.com/6ac869dac34c217329d8a23c8cb4f5472e0758df
Cr-Commit-Position: refs/heads/master@{#365295}