Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1522793002: MiniJsParser: fix a regression + support computed props + add tests (Closed)

Created:
5 years ago by ochafik
Modified:
5 years ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a regression (var decls with rhs), support computed props in class defs + add basic tests. BUG= Committed: https://github.com/dart-lang/dev_compiler/commit/32fa92873d8eade8d47f2f73ea453ec987a77676

Patch Set 1 #

Patch Set 2 : Fix mini-parsing of computed properties + regression on variable decl #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -18 lines) Patch
M lib/src/js/builder.dart View 1 2 3 4 chunks +23 lines, -18 lines 0 comments Download
M test/all_tests.dart View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
A test/js/builder_test.dart View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ochafik
The runtime is coming... here's another preparation CL.
5 years ago (2015-12-13 23:51:58 UTC) #3
ochafik
Committed patchset #4 (id:60001) manually as 32fa92873d8eade8d47f2f73ea453ec987a77676 (presubmit successful).
5 years ago (2015-12-14 01:10:12 UTC) #5
vsm
5 years ago (2015-12-14 01:11:42 UTC) #6
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698