Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 1522683002: Change GPU blacklist for Linux Optiums GPUs. (Closed)

Created:
5 years ago by vmiura
Modified:
4 years, 12 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit), David Yen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change GPU blacklist for Linux Optiums GPUs. The current blacklist entry will exclude any Optimus configuration when GPU driver that isn't "Mesa >= 10.1". This is (unintentionally) blocking GPU on devices where the NVIDIA driver is used. This CL changes the intent so that we blacklist "Mesa < 10.1" rather than "anything except Mesa >= 10.1". BUG=530981 Committed: https://crrev.com/ed3a13d041b422a59df8c0fbfd2f6142887a140c Cr-Commit-Position: refs/heads/master@{#367038}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M gpu/config/software_rendering_list_json.cc View 1 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
vmiura
PTAL
5 years ago (2015-12-11 23:28:29 UTC) #2
vmiura
PTAL
4 years, 12 months ago (2015-12-29 00:05:37 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522683002/1
4 years, 12 months ago (2015-12-29 00:06:34 UTC) #6
Zhenyao Mo
lgtm https://codereview.chromium.org/1522683002/diff/1/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/1522683002/diff/1/gpu/config/software_rendering_list_json.cc#newcode21 gpu/config/software_rendering_list_json.cc:21: "version": "10.16", please update the version to 10.17
4 years, 12 months ago (2015-12-29 00:15:44 UTC) #7
vmiura
https://codereview.chromium.org/1522683002/diff/1/gpu/config/software_rendering_list_json.cc File gpu/config/software_rendering_list_json.cc (right): https://codereview.chromium.org/1522683002/diff/1/gpu/config/software_rendering_list_json.cc#newcode21 gpu/config/software_rendering_list_json.cc:21: "version": "10.16", On 2015/12/29 00:15:44, Zhenyao Mo wrote: > ...
4 years, 12 months ago (2015-12-29 01:01:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522683002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522683002/20001
4 years, 12 months ago (2015-12-29 01:02:49 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 12 months ago (2015-12-29 02:10:37 UTC) #12
commit-bot: I haz the power
4 years, 12 months ago (2015-12-29 02:11:40 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed3a13d041b422a59df8c0fbfd2f6142887a140c
Cr-Commit-Position: refs/heads/master@{#367038}

Powered by Google App Engine
This is Rietveld 408576698