Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1522653002: Use std=c++11 instead of std=gnu++11 everywhere except nacl (Closed)

Created:
5 years ago by jamesr
Modified:
5 years ago
Reviewers:
viettrungluu
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, kulakowski
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use std=c++11 instead of std=gnu++11 everywhere except nacl The pnacl_newlib x86 build still has some errors with std=gnu++11 R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5668be0b2f1cb3d797b6693e8567c2be9e385f83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/services/credentials_unittest.cc View 2 chunks +7 lines, -14 lines 0 comments Download
M skia/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jamesr
This compiles and links in debug/release X fnl X android and the tests pass on ...
5 years ago (2015-12-11 22:07:15 UTC) #2
viettrungluu
lgtm
5 years ago (2015-12-11 22:19:43 UTC) #3
jamesr
5 years ago (2015-12-11 23:31:23 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5668be0b2f1cb3d797b6693e8567c2be9e385f83 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698