Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1522533003: Enable some passing, disabled Intl tests (Closed)

Created:
5 years ago by Dan Ehrenberg
Modified:
5 years ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Enable some passing, disabled Intl tests A couple of the Intl tests made calls to getDefaultTimeZone(), which doesn't exist in V8; however, these were not core to the test. Rather than marking the whole test as failing, just comment out that unimportant part of the test. R=adamk Committed: https://crrev.com/5aa5258e51b68fe6d129aadd4e690c5832763da3 Cr-Commit-Position: refs/heads/master@{#32819}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -8 lines) Patch
M test/intl/date-format/resolved-options.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/intl/date-format/timezone.js View 1 chunk +3 lines, -2 lines 0 comments Download
M test/intl/intl.status View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522533003/1
5 years ago (2015-12-12 01:02:44 UTC) #2
Dan Ehrenberg
5 years ago (2015-12-12 01:04:05 UTC) #3
adamk
lgtm
5 years ago (2015-12-12 01:05:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522533003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522533003/1
5 years ago (2015-12-12 01:05:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-12 01:33:16 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-12 01:34:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5aa5258e51b68fe6d129aadd4e690c5832763da3
Cr-Commit-Position: refs/heads/master@{#32819}

Powered by Google App Engine
This is Rietveld 408576698