Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1522523002: Add more appropriate owners for tools/bisect* and tools/boilerplate.py (Closed)

Created:
5 years ago by rmcilroy
Modified:
5 years ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more appropriate owners for tools/bisect* and tools/boilerplate.py Replaces rmcilroy@ with qyearsley@ and simonhatch@ for bisect related files, and with rsesek@ for boilerplate.py Committed: https://crrev.com/a6ed0d8ccc67308d86f680d16014b50ccca0943c Cr-Commit-Position: refs/heads/master@{#365386}

Patch Set 1 #

Patch Set 2 : Change bisect owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M tools/OWNERS View 1 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
rmcilroy
I'm not a good owner for these files. I've not touched any of them except ...
5 years ago (2015-12-11 16:09:26 UTC) #2
shatch
On 2015/12/11 16:09:26, rmcilroy wrote: > I'm not a good owner for these files. I've ...
5 years ago (2015-12-11 16:16:41 UTC) #3
Robert Sesek
lgtm
5 years ago (2015-12-11 16:22:03 UTC) #4
rmcilroy
Replaced Simon and myself with prasadv@ and robertocn@, PTAL.
5 years ago (2015-12-11 17:02:22 UTC) #6
qyearsley
lgtm
5 years ago (2015-12-11 17:37:57 UTC) #7
Nico
rs-lgtm if the newly added people are happy
5 years ago (2015-12-11 18:08:45 UTC) #8
rmcilroy
prasadv@ / robertocn@, please confirm you are OK with this Owners change.
5 years ago (2015-12-14 10:36:07 UTC) #9
rmcilroy
On 2015/12/14 10:36:07, rmcilroy wrote: > prasadv@ / robertocn@, please confirm you are OK with ...
5 years ago (2015-12-15 22:40:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1522523002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1522523002/20001
5 years ago (2015-12-15 22:41:52 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-15 23:25:20 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-15 23:26:37 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a6ed0d8ccc67308d86f680d16014b50ccca0943c
Cr-Commit-Position: refs/heads/master@{#365386}

Powered by Google App Engine
This is Rietveld 408576698